Enable float32 for LSI - stochastic SVD#1620
Merged
menshikh-iv merged 3 commits intopiskvorky:developfrom Oct 13, 2017
Merged
Conversation
menshikh-iv
reviewed
Oct 11, 2017
- fix float32 for one-pass LSI
Contributor
|
Thanks @isamaru, very useful PR 🔥 |
horpto
pushed a commit
to horpto/gensim
that referenced
this pull request
Oct 28, 2017
* Enable float32 for LSI - stochastic SVD * Fix PEP8 issue * - Add testTransformFloat32 - fix float32 for one-pass LSI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@piskvorky @janpom @menshikh-iv
Enables using float32 in LSI calculation by exposing dtype as parameter. Default remains float64 and the behavior shouldn't change at all unless different dtype is used.