fix: Make trashcan and zoom controls accessible#9768
Merged
Conversation
Contributor
Author
|
This also fixes #9040 |
Contributor
Author
|
This fixes #9041 as well |
mikeharv
approved these changes
Apr 29, 2026
Contributor
mikeharv
left a comment
mikeharv
left a comment
There was a problem hiding this comment.
Looks like a good upgrade. I like the cleaner separation of zoom actions into discrete components. Tab-stop approach and ARIA roles/labels all make sense. It seems well aligned to the current mouse behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9042
Proposed Changes
This PR makes the trashcan and zoom controls accessible via the keyboard. It does this by making them tabstops rather than part of the navigation order, since having to navigate through them with the arrow keys repeatedly would be annoying and frequently unneeded. When focused via the tab key, Enter/Space can be used to act upon them in the same way as a click. Each control has its ARIA role set to
buttonand an appropriate label set. When the trash can is acted upon, the first block in its flyout will be focused.