I changed the orientation notifier to be more "future proof."

Author: ChrisMarshallNY

CHANGELOG.md

@@ -1,5 +1,11 @@
 # RVS_Spinner Change Log
 
+## 2.5.7
+
+- **August 21, 2021**
+
+- I rewrote the deprecated callback to be more "future-proof."
+
 ## 2.5.6
 
 - **August 15, 2021**

README.md

@@ -330,10 +330,6 @@ The "**Highlight Colors**" Segmented Switch allows you to change the [`UIView.ti
 
 ![The HUD Mode Test App (Template SF Symbols Image)](img/HUD-Yellow-Question.png)
 
-TODO
-=
-There is a deprecated callback: the orientation callback (observer) It is on [line 1655](https://github.com/RiftValleySoftware/RVS_Spinner/blob/main/Sources/RVS_Spinner/RVS_Spinner.swift#L1655). We need to address this, but it isn't a showstopper (yet).
-
 LICENSE
 =
 MIT License

RVS_Spinner.xcodeproj/project.pbxproj

@@ -1267,7 +1267,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 2.5.6;
+				MARKETING_VERSION = 2.5.7;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.riftvalleysoftware.RVS-Spinner-Basic-Test-Harness";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_VERSION = 5.0;
@@ -1288,7 +1288,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 2.5.6;
+				MARKETING_VERSION = 2.5.7;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.riftvalleysoftware.RVS-Spinner-Basic-Test-Harness";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_VERSION = 5.0;
@@ -1475,7 +1475,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 2.5.6;
+				MARKETING_VERSION = 2.5.7;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.riftvalleysoftware.RVS-Spinner-Tabbed-Test-Harness";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_VERSION = 5.0;
@@ -1496,7 +1496,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 2.5.6;
+				MARKETING_VERSION = 2.5.7;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.riftvalleysoftware.RVS-Spinner-Tabbed-Test-Harness";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_VERSION = 5.0;
@@ -1519,7 +1519,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 2.5.6;
+				MARKETING_VERSION = 2.5.7;
 				PRODUCT_BUNDLE_IDENTIFIER = com.riftvalleysoftware.Spinner;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_VERSION = 5.0;
@@ -1542,7 +1542,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 2.5.6;
+				MARKETING_VERSION = 2.5.7;
 				PRODUCT_BUNDLE_IDENTIFIER = com.riftvalleysoftware.Spinner;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_VERSION = 5.0;
@@ -1563,7 +1563,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 2.5.6;
+				MARKETING_VERSION = 2.5.7;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.riftvalleysoftware.RVS-Spinner-Leak-Test";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_VERSION = 5.0;
@@ -1584,7 +1584,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 2.5.6;
+				MARKETING_VERSION = 2.5.7;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.riftvalleysoftware.RVS-Spinner-Leak-Test";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_VERSION = 5.0;

Sources/RVS_Spinner/RVS_Spinner.swift

@@ -20,7 +20,7 @@
 
  The Great Rift Valley Software Company: https://riftvalleysoftware.com
 
- - version: 2.5.6
+ - version: 2.5.7
  */
 
 import AudioToolbox
@@ -408,6 +408,8 @@ open class RVS_Spinner: UIControl, UIPickerViewDelegate, UIPickerViewDataSource
     /* ################################################################################################################################## */
     // MARK: - Private Instance Properties
     /* ################################################################################################################################## */
+    private var _registeredOrientationObserver: Bool = false
+    
     /* ################################################################## */
     /**
      This is the display view for the center image.
@@ -1830,6 +1832,12 @@ open class RVS_Spinner: UIControl, UIPickerViewDelegate, UIPickerViewDataSource
 
         super.layoutSubviews()
         _correctRadius()    // Make sure we stay in our lane.
+        
+        // This ensures that the layout is recalculated, when the orientation changes.
+        if !_registeredOrientationObserver {
+            _registeredOrientationObserver = true
+            NotificationCenter.default.addObserver(self, selector: #selector(setNeedsLayout), name: UIDevice.orientationDidChangeNotification, object: nil)
+        }
     }
 
     /* ################################################################################################################################## */
@@ -1865,7 +1873,7 @@ open class RVS_Spinner: UIControl, UIPickerViewDelegate, UIPickerViewDataSource
 
     /* ################################################################## */
     /**
-     We cancel any decelerator display link from here, as well as our orientation notification.
+     We cancel any decelerator display link from here, and remove our listener.
      */
     deinit {
         NotificationCenter.default.removeObserver(self)