updated model associations methods to reflect sequelize v6 model#888
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 117 117
Lines 1126 1126
Branches 129 129
=======================================
Hits 1072 1072
Misses 22 22
Partials 32 32
Continue to review full report at Codecov.
|
theoludwig
reviewed
Jan 21, 2021
theoludwig
left a comment
theoludwig
left a comment
Contributor
There was a problem hiding this comment.
Do you have any link to the sequelize doc or could you give examples of how it changes the way to use sequelize-typescript please ?
Collaborator
Author
|
It doesn't change how to use the methods... It's just remnants of V5 model definition and how mode was initialized. Your model itself is not passed to base model anymore. |
theoludwig
approved these changes
Jan 21, 2021
RobinBuschmann
approved these changes
Jan 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates associations methods signature to reflect sequelize v6 updates and how model is defined. Currently only for compliance with less-strict typings.