[Feature] GitHub Search

[samad-yar-khan]

Issue(s)

closes #12

Acceptance Criteria fulfillment

• Enable user to trigger a search modal using /github search.
• Enable user to enter search queries and fetch relevant results.
• User Should be able to view and select the relevant search results in a another search view modal.
• Users should be able to send selected search result in the desired room.
• Add documentation to the wiki for the GitHub search mechanism and user-flow
• Handle non authenticated users edge cases. (GitHub Search API requires OAuth Token)

Proposed changes (including videos or screenshots)

• Added Documentation for GitHub Search Feature
• Added GitHub Search Modal which allows users to search repository issues and pull request based on different filters.

2022-07-21.21-56-26.mp4

• Added Result Sharing functionality. Enabled user to send selected Pull Request or Issue to current room by clicking on Share. Users can visit the issue/pull request on GitHub by clicking on GitHub button.

2022-07-21.22-04-15.mp4

• Added View Changes button, which will be added to all Pull Request Results. Users can click on View Changes and see more details of the PR, including code changes. ( This can be one of the major painkillers. This will be upgraded to a code editor with indentation depending on the fuselage team PR )

2022-07-21.22-05-38.mp4

Further comments

• Some of the features like reviewing code changes of a PR has been integrated with this Pull Request Change Result to improve collaboration.

[samad-yar-khan]

@RonLek Can you please take a look at this PR and suggest any changes.

[RonLek]

Thanks @samad-yar-khan for your PR. Can we also copy the link to clipboard when the user clicks Share. Do you think that would be possible with the Apps-Engine?

[samad-yar-khan]

Thanks @samad-yar-khan for your PR. Can we also copy the link to clipboard when the user clicks Share. Do you think that would be possible with the Apps-Engine?

@RonLek We can right click on the GitHub Button and copy the link, the GitHub button is linked to that URL. I will see if its possible to add a Copy To Clipboard type of option, that would be a good feature ! But that would ultimately depend on the fuselage implementation, I will take a look :)

[Sing-Li]

Excellent! (I have been skeptical in the recent past about the value of this feature without the ability to review code in detail)

One urgent suggestion is -- in the case of "Share" .....

1. allow multiple "Share" from one search - by toggle-highlighting the SHARE buttons (turning blue/highlighted) and adding a SEND ALL SHARED button at the bottom

2. add a "summary message" free text at the top; it defaults to a description of the search parameters you applied --- but allows user override and editing

Then when "SEND ALL SHARED" is clicked, the "summary message" is appended with each of the highlighted issues and inserted as a larger message into the conversation.

This will "match" a typical usage of this feature significantly better and avoid having to do /github search multiple times in the workflow.

[samad-yar-khan]

@Sing-Li @RonLek I have added the multi-share feature mentioned in the comment. Have a look :)

2022-08-12.21-21-52.mp4

Excellent! (I have been skeptical in the recent past about the value of this feature without the ability to review code in detail)

One urgent suggestion is -- in the case of "Share" .....

1. allow multiple "Share" from one search - by toggle-highlighting the SHARE buttons (turning blue/highlighted) and adding a SEND ALL SHARED button at the bottom
2. add a "summary message" free text at the top; it defaults to a description of the search parameters you applied --- but allows user override and editing

Then when "SEND ALL SHARED" is clicked, the "summary message" is appended with each of the highlighted issues and inserted as a larger message into the conversation.

This will "match" a typical usage of this feature significantly better and avoid having to do /github search multiple times in the workflow.

[RonLek]

Great work @samad-yar-khan . LGTM.