Skip to content

Commit 019b4ee

Browse files
committed
fix(series): extremas would be wrong in some cases with in_header: false
Fixes #725
1 parent eb84693 commit 019b4ee

File tree

2 files changed

+17
-6
lines changed

2 files changed

+17
-6
lines changed

.devcontainer/ui-lovelace.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,6 +1211,15 @@ views:
12111211
}
12121212
title: Synology NAS
12131213
series:
1214+
- entity: sensor.random_0_1000
1215+
name: Test Index
1216+
float_precision: 0
1217+
show:
1218+
extremas: min
1219+
in_chart: false
1220+
group_by:
1221+
duration: 2min
1222+
func: avg
12141223
- entity: sensor.random_0_1000
12151224
name: Min
12161225
float_precision: 0

src/apexcharts-card.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,11 +1024,13 @@ class ChartsCard extends LitElement {
10241024
points: this._config?.series_in_graph.flatMap((serie, index) => {
10251025
if (serie.show.extremas) {
10261026
const { min, max } = this._graphs?.[serie.index]?.minMaxWithTimestamp(
1027-
this._seriesOffset[index]
1028-
? new Date(start.getTime() + this._seriesOffset[index]).getTime()
1027+
this._seriesOffset[serie.index]
1028+
? new Date(start.getTime() + this._seriesOffset[serie.index]).getTime()
10291029
: start.getTime(),
1030-
this._seriesOffset[index] ? new Date(end.getTime() + this._seriesOffset[index]).getTime() : end.getTime(),
1031-
this._serverTimeOffset - (this._seriesTimeDelta[index] || 0),
1030+
this._seriesOffset[serie.index]
1031+
? new Date(end.getTime() + this._seriesOffset[serie.index]).getTime()
1032+
: end.getTime(),
1033+
this._serverTimeOffset - (this._seriesTimeDelta[serie.index] || 0),
10321034
) || {
10331035
min: [0, null],
10341036
max: [0, null],
@@ -1042,7 +1044,7 @@ class ChartsCard extends LitElement {
10421044
extremas.push(
10431045
...this._getPointAnnotationStyle(
10441046
min,
1045-
this._seriesOffset[index],
1047+
this._seriesOffset[serie.index],
10461048
bgColor,
10471049
txtColor,
10481050
serie,
@@ -1058,7 +1060,7 @@ class ChartsCard extends LitElement {
10581060
extremas.push(
10591061
...this._getPointAnnotationStyle(
10601062
max,
1061-
this._seriesOffset[index],
1063+
this._seriesOffset[serie.index],
10621064
bgColor,
10631065
txtColor,
10641066
serie,

0 commit comments

Comments
 (0)