From 007fafbc1ca78e7fcd1ccb943adb8302243847b5 Mon Sep 17 00:00:00 2001 From: RubyJ Date: Tue, 17 Mar 2026 00:03:36 -0400 Subject: [PATCH 1/4] chore: bump version to 1.2.0 --- CooldownTracker.toc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 CooldownTracker.toc diff --git a/CooldownTracker.toc b/CooldownTracker.toc old mode 100644 new mode 100755 index 0f2f2c0..f47e6c9 --- a/CooldownTracker.toc +++ b/CooldownTracker.toc @@ -2,7 +2,7 @@ ## Title: Healer Cooldown Tracker ## Notes: Manually track healer cooldowns for raid leaders. Click to start a timer when a healer calls out on comms. ## Author: Reube -## Version: 1.1.0 +## Version: 1.2.0 ## SavedVariables: CooldownTrackerDB Data.lua From e5a80d51c10f622cc6e1292e4c9bd440819bcc74 Mon Sep 17 00:00:00 2001 From: RubyJ Date: Tue, 17 Mar 2026 00:05:35 -0400 Subject: [PATCH 2/4] chore: run luacheck on pull requests --- .github/workflows/release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fa228a0..4d1c8bc 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -6,6 +6,7 @@ on: - main tags: - "v*" + pull_request: jobs: build: From b1e127fa62c6883f19176e95b57abee6f9e28824 Mon Sep 17 00:00:00 2001 From: RubyJ Date: Tue, 17 Mar 2026 00:09:33 -0400 Subject: [PATCH 3/4] chore: split CI and release into separate workflows --- .github/workflows/ci.yml | 19 +++++++++++++++++++ .github/workflows/release.yml | 8 ++------ 2 files changed, 21 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..5c0c617 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,19 @@ +name: CI + +on: + push: + branches: + - main + pull_request: + +jobs: + lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v4 + + - name: Run Luacheck + uses: nebularg/actions-luacheck@v1 + with: + annotate: warning diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4d1c8bc..26f45a9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,15 +1,12 @@ -name: CI +name: Release on: push: - branches: - - main tags: - "v*" - pull_request: jobs: - build: + release: runs-on: ubuntu-latest steps: @@ -23,7 +20,6 @@ jobs: annotate: warning - name: Package and Release - if: startsWith(github.ref, 'refs/tags/') uses: BigWigsMods/packager@v2 env: GITHUB_OAUTH: ${{ secrets.GITHUB_TOKEN }} From 6fbefd89da8fc70c1f9cc912f1473b6538f16b8c Mon Sep 17 00:00:00 2001 From: RubyJ Date: Tue, 17 Mar 2026 00:12:43 -0400 Subject: [PATCH 4/4] fix: resolve luacheck warnings --- .luacheckrc | 8 +++++++- UI.lua | 1 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.luacheckrc b/.luacheckrc index c8e171b..c8dfc69 100644 --- a/.luacheckrc +++ b/.luacheckrc @@ -1,11 +1,18 @@ std = "lua51" max_line_length = false +ignore = { + "211/AddonName", -- unused variable: idiomatic WoW pattern (local AddonName, CT = ...) + "212/self", -- unused argument: WoW callbacks always receive self; closures use it implicitly + "432/self", -- shadowing upvalue: nested WoW callbacks each receive their own self +} + -- Globals set by this addon globals = { "CooldownTrackerDB", "SLASH_COOLDOWNTRACKER1", "SLASH_COOLDOWNTRACKER2", + "SlashCmdList", -- addon writes SlashCmdList["COOLDOWNTRACKER"] } -- WoW API globals (read-only from this addon's perspective) @@ -18,7 +25,6 @@ read_globals = { "SOUNDKIT", "UIParent", "GameTooltip", - "SlashCmdList", -- Namespaces "C_Timer", "Settings", diff --git a/UI.lua b/UI.lua index 33b5902..44fc84a 100755 --- a/UI.lua +++ b/UI.lua @@ -53,7 +53,6 @@ end -- These functions reanchor all child widgets inside an existing row frame. -- --------------------------------------------------------------------------- local function ApplyWideLayout(row) - local cd = row.cd local rowW = WIDE_W - 16 row:SetSize(rowW, WIDE_ROW_H)