ssh-key: extract a Comment type
#360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts a type which models the concerns of comments, namely that they can be encoded as an RFC4251 `string` type which can hold arbitrary binary data when stored in the binary serialization of a private key. This replaces the various accessor methods on `PublicKey` and `PrivateKey` for handling the various conversions.
tarcieri
force-pushed
the
ssh-key/comment-type
branch
from
609ef1e to
9b7ba63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts a type which models the concerns of comments, namely that they can be encoded as an RFC4251
stringtype which can hold arbitrary binary data when stored in the binary serialization of a private key.This replaces the various accessor methods on
PublicKeyandPrivateKeyfor handling the various conversions.