Add serde for BoxedUInt#587
Conversation
| #[cfg(feature = "serde")] | ||
| impl<'de> Deserialize<'de> for BoxedUint |
There was a problem hiding this comment.
Encoding-related functionality should go under https://github.com/RustCrypto/crypto-bigint/blob/master/src/uint/boxed/encoding.rs
| D: Deserializer<'de>, | ||
| { | ||
| let mut buffer = Self::zero().to_le_bytes(); | ||
| serdect::array::deserialize_hex_or_bin(buffer.as_mut(), deserializer)?; |
There was a problem hiding this comment.
Doesn't work because it doesn't know the size and zero() doesn't size it for the incoming buf
Having some weird errors from the alloc variant
There was a problem hiding this comment.
You need to use serdect::slice if the size isn't known a priori
There was a problem hiding this comment.
hmm I thought I tried (the alloc variant) that and it gave some weird runtime behaviour
|
@tarcieri @pinkforest what's the state here? |
|
The feedback I left hasn't been addressed and the tests aren't yet all passing |
|
Please anyone feel free to cherry on my commit and fix - I got stuck with the alloc version playing up weird. |
|
Closing as stale |
Adapted from RustCrypto#587
3 participants
Missing impl
SerializeandDeserialize