chore: Update yarn setup to cover all packages in the repository (#1875)

Author: SBoudrias

integration/cjs/package.json

@@ -13,5 +13,6 @@
   },
   "engines": {
     "node": ">=18"
-  }
+  },
+  "sideEffects": false
 }

integration/esm/package.json

@@ -14,5 +14,6 @@
   },
   "engines": {
     "node": ">=18"
-  }
+  },
+  "sideEffects": false
 }

internals/hoist-peer-dependencies/package.json

@@ -9,5 +9,6 @@
   },
   "dependencies": {
     "type-fest": "^5.1.0"
-  }
+  },
+  "sideEffects": false
 }

internals/isolate-monorepo-package/package.json

@@ -2,16 +2,7 @@
   "name": "isolate-monorepo-package",
   "version": "1.0.0",
   "private": true,
-  "author": "Simon Boudrias <admin@simonboudrias.com>",
-  "license": "MIT",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/SBoudrias/Inquirer.js.git"
-  },
   "sideEffects": false,
-  "files": [
-    "dist"
-  ],
   "description": "Tool for testing package isolation in Yarn workspace monorepo",
   "type": "module",
   "bin": "./src/bin.ts",
@@ -31,9 +22,5 @@
   },
   "engines": {
     "node": ">=22.3.0"
-  },
-  "publishConfig": {
-    "access": "public",
-    "bin": "./dist/bin.js"
   }
 }

internals/tsconfig/package.json

@@ -8,5 +8,6 @@
   },
   "engines": {
     "node": ">=18"
-  }
+  },
+  "sideEffects": false
 }

internals/tsconfig/tsconfig.json

@@ -4,10 +4,7 @@
     "lib": ["es2023"],
     "skipLibCheck": false,
     "esModuleInterop": true,
-
-    //========== Use filename extension .ts in imports ==========
     "allowImportingTsExtensions": true,
-    // Only needed if compiling to JavaScript
-    "rewriteRelativeImportExtensions": true // from .ts to .js
+    "rewriteRelativeImportExtensions": true
   }
 }

package.json

@@ -58,7 +58,7 @@
     "prepare": "husky && turbo tsc attw",
     "prepack": "find packages/* -maxdepth 1 -type f -name 'README*' -exec sed -i '' -e 's/utm_source=github/utm_source=npmjs/g' {} + && find packages/* -maxdepth 1  -type f -name package.json -exec sh -c 'jq \".devDependencies |= with_entries(select(.value != \\\"workspace:*\\\"))\" \"$1\" > \"$1.tmp\" && mv \"$1.tmp\" \"$1\"' _ {} \\;",
     "postpack": "git restore packages/*/package.json packages/*/README.md",
-    "setup": "node ./tools/setup-packages.ts && prettier --write .",
+    "setup": "node ./tools/setup-packages.ts && prettier --write . --log-level=silent",
     "pretest": "yarn tsc && oxlint && prettier --check . && eslint .",
     "test": "vitest --run packages && turbo test",
     "tsc": "turbo tsc && tsc -p tsconfig.json"

tools/setup-packages.ts

@@ -16,7 +16,12 @@ function readFile(filepath: string) {
 }
 
 function readJSONFile<T>(filepath: string): Promise<T> {
-  return readFile(filepath).then(JSON.parse);
+  return readFile(filepath)
+    .then(JSON.parse)
+    .catch((error: unknown) => {
+      console.error(`Error reading ${filepath}: ${error}`);
+      throw error;
+    });
 }
 
 function fileExists(filepath: string) {
@@ -36,7 +41,7 @@ const versions: Record<string, string> = {};
 const rootPkg = await readJSONFile<TshyPackageJson>(
   path.join(import.meta.dirname, '../package.json'),
 );
-const paths = await globby(['packages/**/package.json', '!**/node_modules']);
+const paths = await globby(['*/*/package.json', '!**/node_modules']);
 
 const packages = await Promise.all(
   paths.map(async (pkgPath: string): Promise<[string, TshyPackageJson]> => {
@@ -53,33 +58,47 @@ for (const [pkgPath, pkg] of packages) {
   const dir = path.dirname(pkgPath);
   fixPeerDeps(path.resolve(path.join(dir)));
 
-  const isTS = await fileExists(path.join(dir, 'src/index.ts'));
+  const isTS =
+    (await fileExists(path.join(dir, 'src/index.ts'))) ||
+    (await fileExists(path.join(dir, 'tsconfig.json')));
   const hasReadme = await fileExists(path.join(dir, 'README.md'));
+  const isPrivate = pkg.private === true;
 
-  // Replicate configs that should always be the same.
-  pkg.engines = rootPkg.engines;
-  pkg.author = rootPkg.author;
-  pkg.license = rootPkg.license;
-  pkg.repository = rootPkg.repository;
-  pkg.keywords = [...new Set([...(rootPkg.keywords ?? []), ...(pkg.keywords ?? [])])];
-  pkg.sideEffects = pkg.sideEffects ?? false;
-  pkg.publishConfig = { access: 'public' };
-
-  if (hasReadme) {
-    const repoPath = dir.split('/').slice(-2).join('/');
-    pkg.homepage = `https://github.com/SBoudrias/Inquirer.js/blob/main/${repoPath}/README.md`;
+  pkg.sideEffects ??= false;
+
+  // Replicate configs that should always be the same on public package.
+  if (!isPrivate) {
+    pkg.author = rootPkg.author;
+    pkg.license = rootPkg.license;
+    pkg.repository = rootPkg.repository;
+    pkg.keywords = [...new Set([...(rootPkg.keywords ?? []), ...(pkg.keywords ?? [])])];
+    pkg.publishConfig = { access: 'public' };
+
+    if (hasReadme) {
+      const repoPath = dir.split('/').slice(-2).join('/');
+      pkg.homepage = `https://github.com/SBoudrias/Inquirer.js/blob/main/${repoPath}/README.md`;
+    }
+  } else {
+    // Remove publishing metadata for private packages
+    delete pkg.author;
+    delete pkg.license;
+    delete pkg.repository;
+    delete pkg.keywords;
+    delete pkg.homepage;
+    delete pkg.publishConfig;
+    delete pkg.files;
   }
 
-  if (isTS) {
+  if (isTS && !isPrivate) {
     pkg.files = ['dist'];
 
-    pkg.devDependencies = pkg.devDependencies ?? {};
+    pkg.devDependencies ??= {};
     pkg.devDependencies['tshy'] = versions['tshy'];
 
-    pkg.tshy = pkg.tshy ?? {};
+    pkg.tshy ??= {};
     pkg.tshy.exclude = ['src/**/*.test.ts'];
 
-    pkg.scripts = pkg.scripts ?? {};
+    pkg.scripts ??= {};
     pkg.scripts['tsc'] = 'tshy';
 
     // Only set attw if the package is using commonjs