Fix dependency cycle caused by reciprocalRunway relationship by changing it to computed var

Author: RISCfuture

SF50 Shared/Defaults.swift

@@ -6,7 +6,7 @@ import SwiftNASR
 // MARK: - Defaults
 
 nonisolated(unsafe) private let groupDefaults = UserDefaults(suiteName: "group.codes.tim.TOLD")!
-public let latestSchemaVersion = 4
+public let latestSchemaVersion = 5
 
 extension Defaults.Keys {
   public static let emptyWeight = Key<Measurement<UnitMass>>(

SF50 Shared/Models/Runway.swift

@@ -75,9 +75,13 @@ public final class Runway {
   @Relationship(deleteRule: .cascade, inverse: \NOTAM.runway)
   public var notam: NOTAM?
 
+  /// Name of the reciprocal runway (e.g., "10R" for runway "28L")
+  public var reciprocalName: String?
+
   /// The reciprocal runway (opposite direction on same surface)
-  @Relationship(deleteRule: .nullify)
-  public var reciprocal: Runway?
+  public var reciprocal: Runway? {
+    airport.runways.first { $0.name == reciprocalName }
+  }
 
   #Unique<Runway>([\.airport, \.name])
 
@@ -234,7 +238,7 @@ public final class Runway {
     _thresholdLatitude = thresholdCoordinate?.latitude
     _thresholdLongitude = thresholdCoordinate?.longitude
     self.airport = airport
-    reciprocal = nil
+    reciprocalName = nil
     notam = nil
   }
 

SF50 Shared/Preview Content/Airport Fixtures/ASE.swift

@@ -52,8 +52,8 @@ extension AirportBuilder {
         airport: airport
       )
 
-      rwy15.reciprocal = rwy33
-      rwy33.reciprocal = rwy15
+      rwy15.reciprocalName = "33"
+      rwy33.reciprocalName = "15"
 
       return [rwy15, rwy33]
     }

SF50 TOLD.xcodeproj/xcshareddata/xcschemes/SF50 TOLD.xcscheme

@@ -33,12 +33,15 @@
             reference = "container:Generate Screenshots/Generate Screenshots.xctestplan">
          </TestPlanReference>
          <TestPlanReference
-            reference = "container:SF50 SharedTests/SF50 Shared Unit Tests.xctestplan"
-            default = "YES">
+            reference = "container:SF50 SharedTests/SF50 Shared Unit Tests.xctestplan">
          </TestPlanReference>
          <TestPlanReference
             reference = "container:SF50 TOLDUITests/SF50 TOLD UI Tests.xctestplan">
          </TestPlanReference>
+         <TestPlanReference
+            reference = "container:SF50 TOLDTests/Unit Tests.xctestplan"
+            default = "YES">
+         </TestPlanReference>
       </TestPlans>
       <Testables>
          <TestableReference

SF50 TOLD/Loaders/AirportLoader/AirportLoader.swift

@@ -195,13 +195,10 @@ actor AirportLoader {
       modelContext.insert(runway)
     }
 
-    // Link reciprocal runways
+    // Set reciprocal runway names
     for runwayData in airport.runways {
-      if let reciprocalName = runwayData.reciprocalName,
-        let runway = runwayMap[runwayData.name],
-        let reciprocal = runwayMap[reciprocalName]
-      {
-        runway.reciprocal = reciprocal
+      if let runway = runwayMap[runwayData.name] {
+        runway.reciprocalName = runwayData.reciprocalName
       }
     }
   }