remove config mix.maxClients + remove idle threads

Author: zeroleak

app/components/MixStatus/index.js

@@ -22,9 +22,7 @@ class MixStatus extends React.PureComponent {
           </div>
           <div className='col-sm-10 mixThreads'>
             <div className='row no-gutters justify-content-center'>
-            {mixService.getThreadsAndIdle().map((utxo,i) => {
-              let content
-              if (utxo !== undefined) {
+              {mixService.getThreads().map((utxo,i) => {
                 const pool = poolsService.findPool(utxo.poolId)
                 const poolInfo = pool ? <small> • {pool.nbConfirmed}/{pool.mixAnonymitySet} peers</small> : undefined
                 const message = utils.utxoMessage(utxo)
@@ -36,32 +34,20 @@ class MixStatus extends React.PureComponent {
                 const progressVariant = utxo.progressPercent ? undefined : 'info'
                 const poolProgress = pool ? (100 - progressPercent) * poolsService.computePoolProgress(pool) / 100 : undefined
 
-                content = <div>
-                    <div className='label'
-                           title={utxo.hash + ':' + utxo.index + ' (' + utxo.account + ') (' + mixService.computeLastActivity(utxo) + ')'}>{progressLabel}</div>
-                      <ProgressBar>
-                        <ProgressBar animated now={progressPercent} variant={progressVariant} key={1}
-                                     className={'progressBarSamourai'+(utxo.mixStep === 'CONNECTING'?' connecting':'')}/>
-                        {poolProgress && <ProgressBar variant="warning" now={poolProgress} key={2}/>}
-                      </ProgressBar>
-                </div>
-              } else {
-                content = <div>
-                  <div className='label'>
-                    <strong>THREAD {(i+1)}</strong><br/>
-                    <small>idle</small>
-                  </div>
-                  <ProgressBar animated now={0} className={'progressBarSamourai'}/>
-                </div>
-              }
-              return <div className='col-sm-3 align-self-center' key={i}>
-                  <div className='row no-gutters'>
-                    <div className='col-sm-12 item'>
-                      {content}
+                return <div className='col-sm-3 align-self-center' key={i}>
+                    <div className='row no-gutters'>
+                      <div className='col-sm-12 item'>
+                        <div className='label'
+                             title={utxo.hash + ':' + utxo.index + ' (' + utxo.account + ') (' + mixService.computeLastActivity(utxo) + ')'}>{progressLabel}</div>
+                        <ProgressBar>
+                          <ProgressBar animated now={progressPercent} variant={progressVariant} key={1}
+                                       className={'progressBarSamourai' + (utxo.mixStep === 'CONNECTING' ? ' connecting' : '')}/>
+                          {poolProgress != undefined && <ProgressBar variant="warning" now={poolProgress} key={2}/>}
+                        </ProgressBar>
+                      </div>
                     </div>
                   </div>
-              </div>
-            })}
+              })}
             </div>
           </div>
           <div className='col-sm-1 mixStatus align-self-center text-center'>

app/containers/ConfigPage.js

@@ -215,19 +215,6 @@ export default class ConfigPage extends Component<Props> {
                 </div>
               </div>
 
-              <div className="form-group row">
-                <label htmlFor="clients" className="col-sm-2 col-form-label">Max clients</label>
-                <div className="col-sm-10">
-                  <div className='row'>
-                    <input type="number" className='form-control col-sm-1' onChange={e => {
-                      const myValue = parseInt(e.target.value)
-                      myThis.onChangeCliConfig(cliConfig => cliConfig.mix.clients = myValue)
-                    }} defaultValue={cliConfig.mix.clients} id="clients"/>
-                    <label className='col-form-label col-sm-11'>Max simultaneous mixing clients</label>
-                  </div>
-                </div>
-              </div>
-
               {clientsPerPoolEditable && <div className="form-group row">
                 <label htmlFor="clientsPerPool" className="col-sm-2 col-form-label">Max clients per pool</label>
                 <div className="col-sm-10">

app/reducers/mix.js

@@ -7,8 +7,6 @@ const initialState = {
   /*mix: {
     started: false,
     nbMixing: 0,
-    maxClients: 0,
-    nbIdle:0,
     nbQueued:0,
     threads: []
   }*/

app/services/mixService.js

@@ -131,14 +131,6 @@ class MixService {
     return this.state.mix.nbMixing;
   }
 
-  getMaxClients() {
-    return this.state.mix.maxClients;
-  }
-
-  getNbIdle() {
-    return this.state.mix.nbIdle;
-  }
-
   getNbQueued() {
     return this.state.mix.nbQueued;
   }
@@ -147,18 +139,6 @@ class MixService {
     return this.state.mix.threads;
   }
 
-  getThreadsAndIdle() {
-    const threadsWithIdle = []
-    for (const i in this.state.mix.threads) {
-      const thread = this.state.mix.threads[i]
-      threadsWithIdle[threadsWithIdle.length] = thread
-    }
-    for (let i = 0; i < this.getNbIdle(); i++) {
-      threadsWithIdle[threadsWithIdle.length] = undefined
-    }
-    return threadsWithIdle;
-  }
-
   fetchState () {
     return ifNot.run('mixService:fetchState', () => {
       // fetchState backend