Skip to content

Commit e1f73d8

Browse files
committed
field descriptions between name and input
1 parent 436841d commit e1f73d8

25 files changed

+78
-71
lines changed

packages/sn-controls-react/src/fieldcontrols/allowed-child-types.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {
22
ClickAwayListener,
33
createStyles,
44
FormGroup,
5-
FormHelperText,
65
IconButton,
76
List,
87
ListItem,
@@ -246,6 +245,8 @@ export const AllowedChildTypes: React.FC<ReactClientFieldSetting & { classes?: A
246245
name={props.settings.Name}
247246
displayName={props.settings.DisplayName}
248247
highlighted={props.settings.Customization?.Highlighted}
248+
description={props.settings.Description}
249+
showDescription={!props.hideDescription}
249250
/>
250251
<List dense={true} className={classes.container}>
251252
{selected.map((item, index) => (
@@ -299,7 +300,6 @@ export const AllowedChildTypes: React.FC<ReactClientFieldSetting & { classes?: A
299300
)}
300301
</List>
301302
</Paper>
302-
{!props.hideDescription && <FormHelperText>{props.settings.Description}</FormHelperText>}
303303
</div>
304304
</div>
305305
</ClickAwayListener>

packages/sn-controls-react/src/fieldcontrols/auto-complete.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ export const AutoComplete: React.FC<ReactClientFieldSetting<ReferenceFieldSettin
5858
name={props.settings.Name}
5959
displayName={props.settings.DisplayName}
6060
highlighted={props.settings.Customization?.Highlighted}
61+
description={props.settings.Description}
62+
showDescription={!props.hideDescription}
6163
/>
6264
<Typography variant="body1" gutterBottom={true}>
6365
{props.fieldValue ? (props.fieldValue as any)[0].DisplayName : localization.noValue}

packages/sn-controls-react/src/fieldcontrols/checkbox-group.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {
77
FormControl,
88
FormControlLabel,
99
FormGroup,
10-
FormHelperText,
1110
makeStyles,
1211
TextField,
1312
Typography,
@@ -98,6 +97,8 @@ export const CheckboxGroup: React.FC<ReactClientFieldSetting<ChoiceFieldSetting>
9897
name={props.settings.Name}
9998
displayName={props.settings.DisplayName}
10099
highlighted={props.settings.Customization?.Highlighted}
100+
description={props.settings.Description}
101+
showDescription={!props.hideDescription}
101102
/>
102103
<FormGroup className={classes.groupCont}>
103104
{props.settings.Options?.map((option) => {
@@ -117,7 +118,6 @@ export const CheckboxGroup: React.FC<ReactClientFieldSetting<ChoiceFieldSetting>
117118
})}
118119
</FormGroup>
119120
{props.settings.AllowExtraValue ? <TextField placeholder="Extra value" /> : null}
120-
{!props.hideDescription && <FormHelperText>{props.settings.Description}</FormHelperText>}
121121
</FormControl>
122122
)
123123
case 'browse':

packages/sn-controls-react/src/fieldcontrols/checkbox.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* @module FieldControls
33
*/
4-
import { FormControl, FormHelperText, Checkbox as MuiCheckbox } from '@material-ui/core'
4+
import { FormControl, Checkbox as MuiCheckbox } from '@material-ui/core'
55
import { deepMerge } from '@sensenet/client-utils'
66
import { FieldSetting } from '@sensenet/default-content-types'
77
import React, { useState } from 'react'
@@ -37,9 +37,10 @@ export const Checkbox: React.FC<ReactClientFieldSetting<FieldSetting>> = (props)
3737
name={props.settings.Name}
3838
displayName={props.settings.DisplayName}
3939
highlighted={props.settings.Customization?.Highlighted}
40+
description={props.settings.Description}
41+
showDescription={!props.hideDescription}
4042
/>
4143
<MuiCheckbox name={props.settings.Name} checked={value} onChange={handleChange} />
42-
{!props.hideDescription && <FormHelperText>{props.settings.Description}</FormHelperText>}
4344
</FormControl>
4445
)
4546
case 'browse':

packages/sn-controls-react/src/fieldcontrols/color-picker.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ export const ColorPicker: React.FC<ReactClientFieldSetting<ColorFieldSetting>> =
5151
name={props.settings.Name}
5252
displayName={props.settings.DisplayName}
5353
highlighted={props.settings.Customization?.Highlighted}
54+
description={props.settings.Description}
55+
showDescription={!props.hideDescription}
5456
/>
5557
<TextField
5658
variant="outlined"
@@ -63,7 +65,6 @@ export const ColorPicker: React.FC<ReactClientFieldSetting<ColorFieldSetting>> =
6365
disabled={props.settings.ReadOnly}
6466
value={value}
6567
onClick={() => setIsPickerOpen(true)}
66-
helperText={props.hideDescription ? undefined : props.settings.Description}
6768
InputProps={{
6869
startAdornment: (
6970
<InputAdornment position="start">

packages/sn-controls-react/src/fieldcontrols/date-picker.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* @module FieldControls
33
*/
4-
import { createStyles, FormHelperText, makeStyles, Theme, Tooltip, Typography } from '@material-ui/core'
4+
import { createStyles, makeStyles, Theme, Tooltip, Typography } from '@material-ui/core'
55
import { deepMerge } from '@sensenet/client-utils'
66
import { DateTimeFieldSetting, DateTimeMode } from '@sensenet/default-content-types'
77
import intlFormatDistance from 'date-fns/intlFormatDistance'
@@ -100,6 +100,8 @@ export const DatePicker: React.FC<ReactClientFieldSetting<DateTimeFieldSetting>>
100100
name={props.settings.Name}
101101
displayName={props.settings.DisplayName}
102102
highlighted={props.settings.Customization?.Highlighted}
103+
description={props.settings.Description}
104+
showDescription={!hideDescription}
103105
/>
104106
<div style={{ maxWidth: '420px' }}>
105107
<DatePickerLib
@@ -117,7 +119,6 @@ export const DatePicker: React.FC<ReactClientFieldSetting<DateTimeFieldSetting>>
117119
isClearable
118120
/>
119121
</div>
120-
{!hideDescription && <FormHelperText>{settings.Description}</FormHelperText>}
121122
</div>
122123
)
123124
default:

packages/sn-controls-react/src/fieldcontrols/dropdown-list.tsx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* @module FieldControls
33
*/
4-
import { FormControl, FormGroup, FormHelperText, MenuItem, Select, Typography } from '@material-ui/core'
4+
import { FormControl, FormGroup, MenuItem, Select, Typography } from '@material-ui/core'
55
import { deepMerge } from '@sensenet/client-utils'
66
import { ChoiceFieldSetting } from '@sensenet/default-content-types'
77
import React, { useState } from 'react'
@@ -57,16 +57,16 @@ export const DropDownList: React.FC<ReactClientFieldSetting<ChoiceFieldSetting>>
5757
case 'edit':
5858
case 'new':
5959
return (
60-
<FormControl
61-
style={{ maxWidth: '420px', width: '100%' }}
62-
required={props.settings.Compulsory}
63-
disabled={props.settings.ReadOnly}>
60+
<FormControl style={{ width: '100%' }} required={props.settings.Compulsory} disabled={props.settings.ReadOnly}>
6461
<CustomLabel
6562
name={props.settings.Name}
6663
displayName={props.settings.DisplayName}
6764
highlighted={props.settings.Customization?.Highlighted}
65+
description={props.settings.Description}
66+
showDescription={!props.hideDescription}
6867
/>
6968
<Select
69+
style={{ maxWidth: '420px', width: '100%' }}
7070
variant="outlined"
7171
onChange={handleChange}
7272
inputProps={
@@ -88,7 +88,6 @@ export const DropDownList: React.FC<ReactClientFieldSetting<ChoiceFieldSetting>>
8888
)
8989
})}
9090
</Select>
91-
{!props.hideDescription && <FormHelperText>{props.settings.Description}</FormHelperText>}
9291
</FormControl>
9392
)
9493
case 'browse':

packages/sn-controls-react/src/fieldcontrols/file-name.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ export const FileName: React.FC<ReactClientFieldSetting> = (props) => {
5050
name={props.settings.Name}
5151
displayName={props.settings.DisplayName}
5252
highlighted={props.settings.Customization?.Highlighted}
53+
description={props.settings.Description}
54+
showDescription={!props.hideDescription}
5355
/>
5456
<TextField
5557
variant="outlined"
@@ -70,7 +72,6 @@ export const FileName: React.FC<ReactClientFieldSetting> = (props) => {
7072
required={props.settings.Compulsory}
7173
disabled={props.settings.ReadOnly}
7274
fullWidth={true}
73-
helperText={props.hideDescription ? undefined : props.settings.Description}
7475
/>
7576
</>
7677
)

packages/sn-controls-react/src/fieldcontrols/file-size.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* @module FieldControls
33
*/
4-
import { FormHelperText, InputAdornment, TextField, Typography } from '@material-ui/core'
4+
import { InputAdornment, TextField, Typography } from '@material-ui/core'
55
import { deepMerge, toNumber } from '@sensenet/client-utils'
66
import { NumberFieldSetting } from '@sensenet/default-content-types'
77
import React, { useState } from 'react'
@@ -52,6 +52,8 @@ export const FileSizeField: React.FC<ReactClientFieldSetting<NumberFieldSetting>
5252
name={props.settings.Name}
5353
displayName={props.settings.DisplayName}
5454
highlighted={props.settings.Customization?.Highlighted}
55+
description={props.settings.Description}
56+
showDescription={!props.hideDescription}
5557
/>
5658
<TextField
5759
variant="outlined"
@@ -75,7 +77,6 @@ export const FileSizeField: React.FC<ReactClientFieldSetting<NumberFieldSetting>
7577
fullWidth={true}
7678
onChange={handleChange}
7779
/>
78-
{!props.hideDescription && <FormHelperText>{props.settings.Description}</FormHelperText>}
7980
</>
8081
)
8182
case 'browse':

packages/sn-controls-react/src/fieldcontrols/file-upload.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {
55
Button,
66
createStyles,
77
FormControl,
8-
FormHelperText,
98
Input,
109
InputLabel,
1110
makeStyles,
@@ -183,6 +182,8 @@ export const FileUpload: React.FC<ReactClientFieldSetting<BinaryFieldSetting>> =
183182
name={props.settings.Name}
184183
displayName={props.settings.DisplayName}
185184
highlighted={props.settings.Customization?.Highlighted}
185+
description={props.settings.Description}
186+
showDescription={!props.hideDescription}
186187
/>
187188
<Typography variant="body1" gutterBottom={true}>
188189
{fileName}
@@ -192,7 +193,6 @@ export const FileUpload: React.FC<ReactClientFieldSetting<BinaryFieldSetting>> =
192193
{localization.buttonText}
193194
</Button>
194195
</InputLabel>
195-
{!props.hideDescription && <FormHelperText>{props.settings.Description}</FormHelperText>}
196196
<Input
197197
style={{ display: 'none' }}
198198
id={`raised-button-file-${props.settings.Name}`}

0 commit comments

Comments
 (0)