From b85625f8074dfe29d248959f76c690ac27841012 Mon Sep 17 00:00:00 2001 From: Sephyi Date: Sun, 19 Apr 2026 19:00:23 +0200 Subject: [PATCH] ci: add dedicated stable-1.94 MSRV verification job MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The existing CI pipeline pinned every job to the same toolchain (`1.94.0`), which meant the `msrv` job did not actually verify the MSRV floor independently — it just ran the same Rust against the same build as `clippy` and `test`. Split the toolchain into two env vars: - `RUST_TOOLCHAIN: stable` for fmt/clippy/test/test-eval (latest) - `MSRV_TOOLCHAIN: "1.94"` for the dedicated `msrv` job Also adjust the `msrv` job so it: - Uses the pinned MSRV toolchain explicitly - Runs with `--all-features --all-targets` to ensure every feature path compiles against the floor - Runs in parallel with other jobs (removed the `needs: fmt` dependency so it cannot be masked by an upstream failure) `cargo check` is kept (vs `cargo test`) since checking is sufficient to prove the MSRV floor compiles without bloating CI runtime. Closes audit entry F-007 from #3. --- .github/workflows/ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 212bd30..419ba9d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,7 +20,8 @@ concurrency: env: CARGO_TERM_COLOR: always RUSTFLAGS: -Dwarnings - RUST_TOOLCHAIN: "1.94.0" + RUST_TOOLCHAIN: "stable" + MSRV_TOOLCHAIN: "1.94" jobs: fmt: @@ -76,17 +77,16 @@ jobs: - run: cargo test --all-targets --features eval msrv: - name: MSRV Check - needs: fmt + name: MSRV (${{ env.MSRV_TOOLCHAIN }}) runs-on: ubuntu-24.04 timeout-minutes: 10 steps: - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@master with: - toolchain: ${{ env.RUST_TOOLCHAIN }} + toolchain: ${{ env.MSRV_TOOLCHAIN }} - uses: Swatinem/rust-cache@v2 - - run: cargo check --all-targets + - run: cargo check --all-features --all-targets dependency-review: name: Dependency Review