From 50a2bb88da5c081d3efe3085af50497f4e2864de Mon Sep 17 00:00:00 2001 From: "luke.kumar" Date: Thu, 17 Oct 2024 09:59:23 -0400 Subject: [PATCH 1/2] call static method --- tools/push_model.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/push_model.py b/tools/push_model.py index 57012c0c2..a6ce2e5ac 100644 --- a/tools/push_model.py +++ b/tools/push_model.py @@ -72,7 +72,7 @@ def _get_commited_iter_numbers(hf_repo: hf_hub.Repository) -> list[int]: print("commits", commits) commits = [c.split(" ", 1)[1] for c in commits] # Keep commits corresponding to a new iter - return [iter_number for c in commits if (iter_number := self.get_iter_number(c)) is not None] + return [iter_number for c in commits if (iter_number := PushConfig._get_iter_number(c)) is not None] @staticmethod def _git_add_safe_directory(directory: pathlib.Path) -> None: From e648bc1e7ec935b3203f18d4f5c7c8f476d2cf8e Mon Sep 17 00:00:00 2001 From: "luke.kumar" Date: Thu, 17 Oct 2024 10:35:11 -0400 Subject: [PATCH 2/2] adding classmethod --- tools/push_model.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/push_model.py b/tools/push_model.py index a6ce2e5ac..78d607d2d 100644 --- a/tools/push_model.py +++ b/tools/push_model.py @@ -58,8 +58,8 @@ def _get_iter_number(maybe_iter_number: str) -> None | int: return int(m.group(1)) return None - @staticmethod - def _get_commited_iter_numbers(hf_repo: hf_hub.Repository) -> list[int]: + @classmethod + def _get_commited_iter_numbers(cls, hf_repo: hf_hub.Repository) -> list[int]: subprocess.run(["git", "fetch", "origin"], cwd=hf_repo.local_dir, capture_output=True) commits = subprocess.run( ["git", "log", "origin/main", "--pretty=format:%H %s"], @@ -72,7 +72,7 @@ def _get_commited_iter_numbers(hf_repo: hf_hub.Repository) -> list[int]: print("commits", commits) commits = [c.split(" ", 1)[1] for c in commits] # Keep commits corresponding to a new iter - return [iter_number for c in commits if (iter_number := PushConfig._get_iter_number(c)) is not None] + return [iter_number for c in commits if (iter_number := cls._get_iter_number(c)) is not None] @staticmethod def _git_add_safe_directory(directory: pathlib.Path) -> None: