Add check to filter out disabled challenges for create/update challenge (Cloud-CV#4766)

gchhablani · web-flow · commit 78eeeb27d4bc · 2025-08-25T09:35:01.000-07:00
This PR adds a check to the method that creates or updates a GitHub challenge to filter out the disabled challenges so that the hosts are unable to update them. 

This is needed because of a recent issue with duplicate challenges being created on multiple updates of the same challenge.
diff --git a/apps/challenges/views.py b/apps/challenges/views.py
@@ -3899,7 +3899,7 @@ def create_or_update_github_challenge(request, challenge_host_team_pk):
         return Response(response_data, status=status.HTTP_406_NOT_ACCEPTABLE)
 
     challenge_queryset = Challenge.objects.filter(
-        github_repository=request.data["GITHUB_REPOSITORY"],
+        github_repository=request.data["GITHUB_REPOSITORY"], is_disabled=False
     )
 
     if challenge_queryset:

Original file line number	Diff line number	Diff line change
`@@ -3899,7 +3899,7 @@ def create_or_update_github_challenge(request, challenge_host_team_pk):`
`3899`	`3899`	`return Response(response_data, status=status.HTTP_406_NOT_ACCEPTABLE)`
`3900`	`3900`
`3901`	`3901`	`challenge_queryset = Challenge.objects.filter(`
`3902`		`- github_repository=request.data["GITHUB_REPOSITORY"],`
	`3902`	`+ github_repository=request.data["GITHUB_REPOSITORY"], is_disabled=False`
`3903`	`3903`	`)`
`3904`	`3904`
`3905`	`3905`	`if challenge_queryset:`