Backend: Remove view-level github branch related infra (Cloud-CV#4746)

* Remove github branch filter from create or update github challenge

* Remove tests related to github branch

* Remove remaining assert in challenge creation

* Remove success test entirely

* Add back github success test

* Remove view-level infra

* Remove success test

---------

Co-authored-by: Rishabh Jain <rishabhjain2018@gmail.com>

Author: gchhablani

apps/challenges/challenge_config_utils.py

@@ -586,9 +586,6 @@ def validate_serializer(self):
                     "github_repository": self.request.data[
                         "GITHUB_REPOSITORY"
                     ],
-                    "github_branch": self.request.data.get(
-                        "GITHUB_BRANCH_NAME", ""
-                    ),
                 },
             )
             if not serializer.is_valid():

apps/challenges/views.py

@@ -3897,12 +3897,8 @@ def create_or_update_github_challenge(request, challenge_host_team_pk):
         response_data = {"error": "ChallengeHostTeam does not exist"}
         return Response(response_data, status=status.HTTP_406_NOT_ACCEPTABLE)
 
-    # Get branch name with default fallback
-    github_branch = request.data.get("GITHUB_BRANCH_NAME", "")
-
     challenge_queryset = Challenge.objects.filter(
         github_repository=request.data["GITHUB_REPOSITORY"],
-        github_branch=github_branch,
     )
 
     if challenge_queryset:
@@ -3983,7 +3979,6 @@ def create_or_update_github_challenge(request, challenge_host_team_pk):
                             "github_repository": request.data[
                                 "GITHUB_REPOSITORY"
                             ],
-                            "github_branch": github_branch,
                             "worker_image_url": worker_image_url,
                         },
                     )

scripts/seed.py

@@ -256,7 +256,6 @@ def create_challenge(
         featured=is_featured,
         image=image_file,
         github_repository=f"evalai-examples/{slug}",
-        github_branch="main",
     )
     challenge.save()
 

tests/unit/challenges/test_views.py

@@ -5917,45 +5917,6 @@ def setUp(self):
 
         self.client.force_authenticate(user=self.user)
 
-    def test_create_challenge_using_github_success(self):
-        self.url = reverse_lazy(
-            "challenges:create_or_update_github_challenge",
-            kwargs={"challenge_host_team_pk": self.challenge_host_team.pk},
-        )
-
-        with mock.patch("challenges.views.requests.get") as m:
-            resp = mock.Mock()
-            resp.content = self.test_zip_file.read()
-            resp.status_code = 200
-            m.return_value = resp
-            response = self.client.post(
-                self.url,
-                {
-                    "GITHUB_REPOSITORY": "https://github.com/yourusername/repository",
-                    "GITHUB_BRANCH_NAME": "refs/heads/challenge",
-                    "zip_configuration": self.input_zip_file,
-                },
-                format="multipart",
-            )
-            expected = {
-                "Success": "Challenge Challenge Title has been created successfully and sent for review to EvalAI Admin."
-            }
-
-            self.assertEqual(response.status_code, 201)
-            self.assertEqual(response.json(), expected)
-        self.assertEqual(Challenge.objects.count(), 1)
-        self.assertEqual(DatasetSplit.objects.count(), 1)
-        self.assertEqual(Leaderboard.objects.count(), 1)
-        self.assertEqual(ChallengePhaseSplit.objects.count(), 1)
-
-        # Verify github_branch is properly stored
-        challenge = Challenge.objects.first()
-        self.assertEqual(
-            challenge.github_repository,
-            "https://github.com/yourusername/repository",
-        )
-        self.assertEqual(challenge.github_branch, "refs/heads/challenge")
-
     def test_create_challenge_using_github_when_challenge_host_team_does_not_exist(
         self,
     ):
@@ -5994,40 +5955,6 @@ def test_create_challenge_using_github_when_user_is_not_authenticated(
         self.assertEqual(list(response.data.values())[0], expected["error"])
         self.assertEqual(response.status_code, status.HTTP_401_UNAUTHORIZED)
 
-    def test_create_challenge_using_github_without_branch_name(self):
-        self.url = reverse_lazy(
-            "challenges:create_or_update_github_challenge",
-            kwargs={"challenge_host_team_pk": self.challenge_host_team.pk},
-        )
-
-        with mock.patch("challenges.views.requests.get") as m:
-            resp = mock.Mock()
-            resp.content = self.test_zip_file.read()
-            resp.status_code = 200
-            m.return_value = resp
-            response = self.client.post(
-                self.url,
-                {
-                    "GITHUB_REPOSITORY": "https://github.com/yourusername/repository",
-                    "zip_configuration": self.input_zip_file,
-                },
-                format="multipart",
-            )
-            expected = {
-                "Success": "Challenge Challenge Title has been created successfully and sent for review to EvalAI Admin."
-            }
-
-            self.assertEqual(response.status_code, 201)
-            self.assertEqual(response.json(), expected)
-
-        # Verify github_branch defaults to empty string when not provided
-        challenge = Challenge.objects.first()
-        self.assertEqual(
-            challenge.github_repository,
-            "https://github.com/yourusername/repository",
-        )
-        self.assertEqual(challenge.github_branch, "")
-
 
 class ValidateChallengeTest(APITestCase):
     def setUp(self):