Skip to content

Victory/Loss Conditions, Weapon Sway bug fix#299

Merged
stutpip123 merged 30 commits intounstablefrom
Maxx
Sep 25, 2024
Merged

Victory/Loss Conditions, Weapon Sway bug fix#299
stutpip123 merged 30 commits intounstablefrom
Maxx

Conversation

@UAC-MaxxLite
Copy link
Copy Markdown
Collaborator

@UAC-MaxxLite UAC-MaxxLite commented Aug 27, 2024

What type of PR is this?

  1. Bug
  2. Change
  3. Enhancement
  4. Miscellaneous

What have you changed and why?

Information:
Added:
Parameters:

Victory Conditions:

  1. Normal Victory (Default): more the 50% support and capture all airports and military bases
  2. Total Victory: more the 50% support and capture all Airports, military bases, outposts, factories and resources
  3. Economic Win : get 2 million of the currency used
  4. Logistical Win: get control of all airports seaports and military bases
  5. Political Win: get more the 75% of the population to support you

Added a button in the commander menu to check if the conditions have been achieved and if not show what you are missing using a hint

Loss Conditions:

  1. Population Death: if more then 33% of the population dies
  2. HR loss: if you run out of HR after war level 1
  3. Economic loss: when you run out of money at any point
  4. HARDCORE: all loss conditions combined

changed to when the loss condition is triggered

Lose HR on player death
Added a parameter with 3 options (Disabled, Enabled, Enabled with alerts)
info:
if enabled when a player dies a set amount of HR will be removed from the HR pool acting as respawns
if enabled with alerts when a player dies or when you are low on HR an alert will appear at the top of the screen warning you

  • War level 1 = no HR loss
  • War level 2-3 = 1 HR loss
  • War level 4-6 = 5 HR loss
  • War level 7+ = 10 HR loss

Limit HR

  • Adds an option to limit the amount of HR a player faction can obtain depending on war level
  • War level 1: Max HR = 200.
  • War level 2: Max HR = 300.
  • War level 3: Max HR = 400.
  • War level 4: Max HR = 550.
  • War level 5: Max HR = 700.
  • War level 6: Max HR = 850.
  • War level 7: Max HR = 1000.
  • War level 8: Max HR = 1200.
  • War level 9: Max HR = 1400.
  • War level 10: Max HR = 1600.

Bug fix

  • Fixed issue where weapon sway calculation did work correctly

Please specify which Issue this PR Resolves (If Applicable).

"This PR closes #XXXX!"

Please verify the following.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
test out the economic victory for balancing reasons
test out political victory to see if any issues occur


Notes:

Comment thread A3A/addons/core/Params.hpp
Comment thread A3A/addons/core/Stringtable.xml Outdated
Comment thread A3A/addons/core/functions/init/fn_briefing.sqf Outdated
@Silence-112 Silence-112 added the misc A miscellaneous change label Aug 27, 2024
@UAC-MaxxLite
Copy link
Copy Markdown
Collaborator Author

UAC-MaxxLite commented Aug 28, 2024

i have put totalVictory back in @SilenceIsFatto

Copy link
Copy Markdown
Member

@Silence-112 Silence-112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now

@UAC-MaxxLite
Copy link
Copy Markdown
Collaborator Author

seems like it might be ready. gonna take a good look and test it a lot more. thinking about making the HR limit a param

@UAC-MaxxLite
Copy link
Copy Markdown
Collaborator Author

this is a big change and there is a big amount of code. not sure if i 100% made it work good but it does work on lan hosting

@UAC-MaxxLite UAC-MaxxLite self-assigned this Sep 13, 2024
Copy link
Copy Markdown
Member

@Silence-112 Silence-112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once changes have been resolved, i'd say it's ready for testing

Comment thread A3A/addons/core/functions/Base/fn_resourcesFIA.sqf Outdated
Comment thread A3A/addons/core/functions/Base/fn_statistics.sqf Outdated
Comment thread A3A/addons/core/functions/init/fn_resourcecheck.sqf
Comment thread A3A/addons/core/functions/Base/fn_checkLossCondition.sqf Outdated
Comment thread A3A/addons/core/functions/Base/fn_checkWinCondition.sqf Outdated
Comment thread A3A/addons/core/functions/Base/fn_checkWinCondition.sqf Outdated
Comment thread A3A/addons/core/functions/Base/fn_checkWinCondition.sqf
@UAC-MaxxLite UAC-MaxxLite changed the title Victory Conditions Victory/Loss Conditions, Weapon Sway bug fix Sep 15, 2024
@Silence-112 Silence-112 added this to the v11.2.0 milestone Sep 16, 2024
Comment thread A3A/addons/core/functions/Base/fn_resourcesFIA.sqf Outdated
Comment thread A3A/addons/core/functions/Base/fn_statistics.sqf Outdated
Comment thread A3A/addons/core/functions/init/fn_resourcecheck.sqf Outdated
UAC-MaxxLite and others added 3 commits September 17, 2024 13:20
Co-authored-by: Silence <78276788+SilenceIsFatto@users.noreply.github.com>
Co-authored-by: Silence <78276788+SilenceIsFatto@users.noreply.github.com>
Co-authored-by: Silence <78276788+SilenceIsFatto@users.noreply.github.com>
Copy link
Copy Markdown
Member

@Silence-112 Silence-112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good for testing

@stutpip123 stutpip123 merged commit 1dd0e2d into unstable Sep 25, 2024
@Silence-112 Silence-112 mentioned this pull request Oct 7, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

misc A miscellaneous change ready-for-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants