Victory/Loss Conditions, Weapon Sway bug fix#299
Merged
stutpip123 merged 30 commits intounstablefrom Sep 25, 2024
Merged
Conversation
Silence-112
requested changes
Aug 27, 2024
Collaborator
Author
|
i have put totalVictory back in @SilenceIsFatto |
Collaborator
Author
|
seems like it might be ready. gonna take a good look and test it a lot more. thinking about making the HR limit a param |
Collaborator
Author
|
this is a big change and there is a big amount of code. not sure if i 100% made it work good but it does work on lan hosting |
Silence-112
requested changes
Sep 15, 2024
Member
Silence-112
left a comment
There was a problem hiding this comment.
Once changes have been resolved, i'd say it's ready for testing
Silence-112
requested changes
Sep 16, 2024
Co-authored-by: Silence <78276788+SilenceIsFatto@users.noreply.github.com>
Co-authored-by: Silence <78276788+SilenceIsFatto@users.noreply.github.com>
Co-authored-by: Silence <78276788+SilenceIsFatto@users.noreply.github.com>
Silence-112
approved these changes
Sep 18, 2024
Member
Silence-112
left a comment
There was a problem hiding this comment.
Should be good for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What have you changed and why?
Information:
Added:
Parameters:
Victory Conditions:
Added a button in the commander menu to check if the conditions have been achieved and if not show what you are missing using a hint
Loss Conditions:
changed to when the loss condition is triggered
Lose HR on player death
Added a parameter with 3 options (Disabled, Enabled, Enabled with alerts)
info:
if enabled when a player dies a set amount of HR will be removed from the HR pool acting as respawns
if enabled with alerts when a player dies or when you are low on HR an alert will appear at the top of the screen warning you
Limit HR
Bug fix
Please specify which Issue this PR Resolves (If Applicable).
"This PR closes #XXXX!"
Please verify the following.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
test out the economic victory for balancing reasons
test out political victory to see if any issues occur
Notes: