Skip to content

Commit 03b6cfc

Browse files
committed
Add support for Windows credential manager.
Signed-off-by: David Calavera <david.calavera@gmail.com>
1 parent dd7a71b commit 03b6cfc

File tree

5 files changed

+103
-0
lines changed

5 files changed

+103
-0
lines changed

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ osxkeychain:
1010
mkdir -p bin
1111
go build -o bin/docker-credential-osxkeychain osxkeychain/cmd/main_darwin.go
1212

13+
wincred:
14+
mkdir -p bin
15+
go build -o bin/docker-credential-wincred wincred/cmd/main_windows.go
16+
1317
test:
1418
go test -v ./...
1519

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ Set the `credsStore` option in your `.docker/config.json` file with the suffix o
3838
### Available programs
3939

4040
1. osxkeychain: Provides a helper to use the OS X keychain as credentials store.
41+
2. wincred: Provides a helper to use Windows credentials manager as store.
4142

4243
## Development
4344

wincred/cmd/main_windows.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package main
2+
3+
import (
4+
"github.com/docker/docker-credential-helpers/credentials"
5+
"github.com/docker/docker-credential-helpers/wincred"
6+
)
7+
8+
func main() {
9+
credentials.Serve(wincred.New())
10+
}

wincred/wincred_windows.go

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
package wincred
2+
3+
import (
4+
winc "github.com/danieljoos/wincred"
5+
"github.com/docker/docker-credential-helpers/credentials"
6+
)
7+
8+
type wincred struct{}
9+
10+
// New creates a new wincred.
11+
func New() credentials.Helper {
12+
return wincred{}
13+
}
14+
15+
// Add adds new credentials to the windows credentials manager.
16+
func (h wincred) Add(creds *credentials.Credentials) error {
17+
g := winc.NewGenericCredential(creds.ServerURL)
18+
g.UserName = creds.Username
19+
g.CredentialBlob = []byte(creds.Password)
20+
g.Persist = winc.PersistLocalMachine
21+
return g.Write()
22+
}
23+
24+
// Delete removes credentials from the windows credentials manager.
25+
func (h wincred) Delete(serverURL string) error {
26+
g, err := winc.GetGenericCredential(serverURL)
27+
if g == nil {
28+
return nil
29+
}
30+
if err != nil {
31+
return err
32+
}
33+
return g.Delete()
34+
}
35+
36+
// Get retrieves credentials from the windows credentials manager.
37+
func (h wincred) Get(serverURL string) (string, string, error) {
38+
g, _ := winc.GetGenericCredential(serverURL)
39+
if g == nil {
40+
return "", "", credentials.ErrCredentialsNotFound
41+
}
42+
return g.UserName, string(g.CredentialBlob), nil
43+
}

wincred/wincred_windows_test.go

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
package wincred
2+
3+
import (
4+
"testing"
5+
6+
"github.com/docker/docker-credential-helpers/credentials"
7+
)
8+
9+
func TestWinCredHelper(t *testing.T) {
10+
creds := &credentials.Credentials{
11+
ServerURL: "https://foobar.docker.io:2376/v1",
12+
Username: "foobar",
13+
Password: "foobarbaz",
14+
}
15+
16+
helper := New()
17+
if err := helper.Add(creds); err != nil {
18+
t.Fatal(err)
19+
}
20+
21+
username, password, err := helper.Get(creds.ServerURL)
22+
if err != nil {
23+
t.Fatal(err)
24+
}
25+
26+
if username != "foobar" {
27+
t.Fatalf("expected %s, got %s\n", "foobar", username)
28+
}
29+
30+
if password != "foobarbaz" {
31+
t.Fatalf("expected %s, got %s\n", "foobarbaz", password)
32+
}
33+
34+
if err := helper.Delete(creds.ServerURL); err != nil {
35+
t.Fatal(err)
36+
}
37+
}
38+
39+
func TestMissingCredentials(t *testing.T) {
40+
helper := New()
41+
_, _, err := helper.Get("https://adsfasdf.wrewerwer.com/asdfsdddd")
42+
if err != credentials.ErrCredentialsNotFound {
43+
t.Fatalf("exptected ErrCredentialsNotFound, got %v", err)
44+
}
45+
}

0 commit comments

Comments
 (0)