Fix dnd reordering in linked files (JabRef#14627)

* Fix dnd reordering in linked files

Follow up from JabRef#12871

* changelog

Author: Siedlerchr

CHANGELOG.md

@@ -57,6 +57,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We fixed localization of the "New Entries" dialog. [#14455](https://github.com/JabRef/jabref/pull/14455)
 - We fixed an issue where keybindings could not be edited and saved. [#14237](https://github.com/JabRef/jabref/issues/14237)
 - We readded the missing gui commands for importing and exporting preferences. [#14492](https://github.com/JabRef/jabref/pull/14492)
+- We fixed an issue where reordering linked files via drag and drop was no longer possible [14627](https://github.com/JabRef/jabref/pull/14627)
 
 ### Removed
 

jabgui/src/main/java/org/jabref/gui/util/ViewModelListCellFactory.java

@@ -8,6 +8,7 @@
 
 import javafx.beans.value.ObservableValue;
 import javafx.css.PseudoClass;
+import javafx.event.Event;
 import javafx.scene.Node;
 import javafx.scene.control.ComboBox;
 import javafx.scene.control.ContextMenu;
@@ -193,9 +194,16 @@ protected void updateItem(T item, boolean empty) {
                     }
                     if (toOnDragDropped != null) {
                         setOnDragDropped(event -> {
-                            // The parent is the box for dropping; that should be used as target (and not this cell)
+                            // For reordering we need to accept the event so that the local handlers get it
+                            toOnDragDropped.accept(viewModel, event);
+                            Node parent = getParent();
+                            if (parent != null) {
+                                // The parent is the box for dropping from external files; that should be used as target (and not this cell)
+                                // We need to send a copy of the event before consuming the original one
+                                DragEvent forwarded = event.copyFor(parent, parent);
+                                Event.fireEvent(parent, forwarded);
+                            }
                             event.consume();
-                            getParent().fireEvent(event);
                         });
                     }
                     if (toOnDragEntered != null) {
@@ -206,8 +214,14 @@ protected void updateItem(T item, boolean empty) {
                     }
                     if (toOnDragOver != null) {
                         setOnDragOver(event -> {
-                            event.consume(); // Prevent cells from acting as drop targets
-                            getParent().fireEvent(event); // The action performed was not look at the parent, the drop box
+                            // For reordering we need to accept the event so that the local handlers get it
+                            toOnDragOver.accept(viewModel, event);
+                            Node parent = getParent();
+                            if (parent != null) {
+                                DragEvent forwarded = event.copyFor(parent, parent);
+                                Event.fireEvent(parent, forwarded);
+                            }
+                            event.consume();
                         });
                     }
                     for (Map.Entry<PseudoClass, Callback<T, ObservableValue<Boolean>>> pseudoClassWithCondition : pseudoClasses.entrySet()) {