Update SharedInfrastructure for Xunit V3#2854
Open
stefannikolei wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
I started looking into it. Gonna take longer. This is not a small change. |
# Conflicts: # shared-infrastructure
stefannikolei
force-pushed
the
sn/upd/xunit
branch
from
1bb255f to
29ff145
Compare
Member
|
You’re a brave man! XUnit versioning is a shambles. |
Contributor
Author
|
@JimBobSquarePants Just small changes then it should work. But those changes are 🤮 Will have to clean it up. I just saw that there are some unrelated changes. |
Breaking changes addressed: - Update xunit.v3 to 3.2.2 and xunit.runner.visualstudio to 3.1.5 - Remove Microsoft.DotNet.XUnitExtensions (conflicts with xunit.v3 via xunit.core v2) - Replace ConditionalFact/ConditionalTheory with Fact/Theory SkipUnless/SkipWhen/SkipType - Remove 'using Xunit.Abstractions' (ITestOutputHelper now in Xunit namespace globally) - Fix TestFrameworkAttribute: string args → typeof(T) form - Fix XunitTestFramework ctor: no longer takes IMessageSink - Fix BeforeAfterTestAttribute Before/After: added IXunitTest parameter, use Xunit.v3 ns - Fix DataAttribute: new GetData signature (DisposalTracker), add SupportsDiscoveryEnumeration() - Fix IXunitSerializable/IXunitSerializationInfo: add 'using Xunit.Sdk' to all consumers - Fix BasicSerializer: implement new IXunitSerializationInfo.GetValue(string) returning object? Store type info in dump format (key:TypeAQN:value) to enable typed reconstruction - Fix TheoryData<T> CS0121 ambiguity on C# 12/net8.0: add explicit casts (T)value Affects ExifValuesTests, PixelOperationsTests, QuantizerTests, DitherTests, TestImageProviderTests, RotateTests, L8Tests, La16Tests - Fix PngEncoderTests: TheoryData<T> now yields TheoryDataRow<T>, not object[]
stefannikolei
force-pushed
the
sn/upd/xunit
branch
from
1113a0f to
d50cba9
Compare
when used in nameof it is not allowed to be a filed it must be a property
stefannikolei
force-pushed
the
sn/upd/xunit
branch
from
1233a91 to
29ff120
Compare
Contributor
Author
|
@JimBobSquarePants so i finale succeeded. If you want you can have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submodule points to my fork for iterating faster. When this works, I will create a mr in the SharedInfrastructure project