Skip to content

Commit 067454b

Browse files
committed
support >= and <= in version filtering, fix 'present in' filtering
1 parent 1ce1db6 commit 067454b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/components/syntaxes/SyntaxDisplayManager.astro

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface Version {
1919
2020
export interface VersionFilterData {
2121
versions: Version[];
22-
range: 'strict' | 'above' | 'below';
22+
range: 'strict' | 'above' | 'below' | 'below_and_equal' | 'above_and_equal';
2323
type: 'any' | 'added' | 'changed';
2424
}
2525
---
@@ -155,9 +155,9 @@ export interface VersionFilterData {
155155

156156
const result = compareVersions(desired, provided);
157157
// process range
158-
if ((result === 0 && versionFilter.range !== 'strict')
159-
|| (result === 1 && versionFilter.range !== 'below')
160-
|| (result === -1 && versionFilter.range !== 'above')) {
158+
if ((result === 0 && (versionFilter.range == 'above' || versionFilter.range == 'below'))
159+
|| (result === 1 && versionFilter.range !== 'below' && versionFilter.range !== 'below_and_equal')
160+
|| (result === -1 && versionFilter.range !== 'above' && versionFilter.range !== 'above_and_equal')) {
161161
continue;
162162
}
163163

src/components/syntaxes/filters/VersionFilter.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ const INITIAL_VISIBLE_COUNT = 3;
124124
let filterData: VersionFilterData;
125125

126126
if (versionFilterType === 'present') {
127-
filterData = { versions: [], range: 'below', type: 'any' };
127+
filterData = { versions: [], range: 'below_and_equal', type: 'any' };
128128
} else if (versionFilterType === 'changed') {
129129
filterData = { versions: [], range: 'strict', type: 'changed' };
130130
} else if (versionFilterType === 'added') {

0 commit comments

Comments
 (0)