From 489d4953866d0657b0f3fde44af6221a408e2d19 Mon Sep 17 00:00:00 2001 From: janiskemper Date: Mon, 22 Jul 2024 12:03:08 +0200 Subject: [PATCH] :bug: Show correct latest release per ClusterStack We have shown always the same ClusterStackRelease as latest release, even if it was a ClusterStack that does not own the ClusterStackRelease. This was because we have in theory correctly searched for the latest release, but then have not taken it due to a mistake with the wrong index of a for loop Signed-off-by: Thomas Guettler --- internal/controller/clusterstack_controller.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/controller/clusterstack_controller.go b/internal/controller/clusterstack_controller.go index 9f0ceb84..7a6e6c0f 100644 --- a/internal/controller/clusterstack_controller.go +++ b/internal/controller/clusterstack_controller.go @@ -444,8 +444,8 @@ func (r *ClusterStackReconciler) getExistingClusterStackReleases(ctx context.Con for i := range csrList.Items { csr := csrList.Items[i] - for i := range csr.GetOwnerReferences() { - ownerRef := csr.GetOwnerReferences()[i] + for j := range csr.GetOwnerReferences() { + ownerRef := csr.GetOwnerReferences()[j] if matchesOwnerRef(&ownerRef, clusterStack) { existingClusterStackReleases = append(existingClusterStackReleases, &csrList.Items[i]) break