[1.x] Make AbstractWorkRegistry respect the current worker of a node#1433
Merged
Conversation
yevhenii-nadtochii
changed the title
ShardedWorkRegistry use WorkerId instead of NodeIdShardedWorkRegistry use WorkerId
Codecov Report
@@ Coverage Diff @@
## 1.x-dev #1433 +/- ##
=============================================
+ Coverage 90.99% 91.00% +0.01%
- Complexity 4813 4814 +1
=============================================
Files 616 616
Lines 15294 15302 +8
Branches 864 864
=============================================
+ Hits 13917 13926 +9
+ Misses 1105 1104 -1
Partials 272 272 |
added 6 commits
December 14, 2021 15:08
yevhenii-nadtochii
changed the title
ShardedWorkRegistry use WorkerIdAbstractWorkRegistry respect the current worker of the node
yevhenii-nadtochii
changed the title
AbstractWorkRegistry respect the current worker of the nodeAbstractWorkRegistry respect the current worker of a node
armiol
approved these changes
Dec 15, 2021
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@yevhenii-nadtochii LGTM with some things to fix according to the written comments and vocal discussion.
yevhenii-nadtochii
changed the title
AbstractWorkRegistry respect the current worker of a nodeAbstractWorkRegistry respect the current worker of a node
added 2 commits
December 15, 2021 12:36
This was referenced Dec 15, 2021
Merged
This was referenced Dec 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
ShardSessionRecordusedNodeIdto indicate who is currently processing which shard.On an application node, several workers (threads) can be used to deliver messages. Thus, their identifiers should be used in registry to clearly say who is processing the shard.
This PR updates
AbstractWorkRegistryto request the current node'sWorkerIdto use it inShardSessionRecord.WorkerIdstores information about the node it belongs and an a worker identifier itself (typically, a thread ID).The library version is bumped to
1.7.7-SNAPSHOT.8.