build: update tsconfig target and remove dist folder from git repo#8
Merged
Conversation
jrebocho
reviewed
Mar 29, 2023
jrebocho
approved these changes
Mar 29, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
## [1.0.11](v1.0.10...v1.0.11) (2023-03-29) ### Bug Fixes * update tsconfig target and remove dist folder from git repo ([#8](#8)) ([7b25db8](7b25db8))
|
🎉 This PR is included in version 1.0.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reachdesk is getting this error:
This is because of the tsconfig target building for ESNext which supports features like optional chaining and type coalescence.
We could go lower than ES2018 (eg: to ES2016) if we think there's a risk T2s use non-ES2018 compatible browsers.
Also removing the
distfolder as it shouldn't be needed (and removing it from.releasercgit plugin config should prevent it from being committed again)