Add testRequestURLsAreDeterministic

Author: StarLard

Sources/StormGlassKit/API/StormGlassKit+API.swift

@@ -112,9 +112,6 @@ internal extension StormGlassKit {
         if let sources = sources, !sources.isEmpty {
             queryItems.append(URLQueryItem(name: "source", value: sources.map(\.rawValue).joined(separator: ",")))
         }
-        queryItems.sort { lhs, rhs in
-            lhs.name < rhs.name
-        }
         let components = urlComponents(apiEndpoint: "weather/point", queryItems: queryItems)
         guard let url = components.url else { throw StormGlassKitNetworkError.invalidRequest(reason: "Invalid URL components: \(components.description)") }
         var request: URLRequest = URLRequest(url: url)

Tests/StormGlassKitTests/NetworkingTests.swift

@@ -17,24 +17,23 @@ final class NetworkingTests: XCTestCase {
             URLQueryItem(name: "params", value: "swellHeight,airTemperature"),
         ]
         let components = StormGlassKit.urlComponents(apiEndpoint: "weather/point", queryItems: queryItems)
-        
+
         guard let url = components.url else {
             XCTFail("Components URL was nil")
             return
         }
-        
+
         XCTAssertEqual(url.absoluteString,
                        "https://api.stormglass.io/v2/weather/point?lat=19.594379&lng=-155.971668&params=swellHeight,airTemperature")
     }
-    
-    @MainActor func testRequestURL() throws {
+
+    func testRequestURLIncludesAuthorization() throws {
         let apiKey = "iLikeTurtles"
         let coordinate = CLLocationCoordinate2D(latitude: 19.594379, longitude: -155.971668)
         let measurements: Set<WeatherMeasurementName> = [.swellHeight, .airTemperature]
         let start = Date(timeIntervalSince1970: 1635760800.0)
         let end = Date(timeIntervalSince1970: 1635847200.0)
-        
-        StormGlassKit.configure(with: .init(apiKey: apiKey))
+
         let request = try StormGlassKit.weatherURLRequest(
             apiKey: apiKey,
             coordinate: coordinate,
@@ -45,4 +44,30 @@ final class NetworkingTests: XCTestCase {
         )
         XCTAssertEqual(request.value(forHTTPHeaderField: "Authorization"), apiKey)
     }
+
+    func testRequestURLsAreDeterministic() throws {
+        let apiKey = "iLikeTurtles"
+        let coordinate = CLLocationCoordinate2D(latitude: 19.594379, longitude: -155.971668)
+        let measurements = Set(WeatherMeasurementName.allCases)
+        let start = Date(timeIntervalSince1970: 1635760800.0)
+        let end = Date(timeIntervalSince1970: 1635847200.0)
+        let sources = Set(WeatherDataSource.allCases)
+
+        var previousRequestURL: URL?
+        for _ in 0..<100 {
+            let request = try StormGlassKit.weatherURLRequest(
+                apiKey: apiKey,
+                coordinate: coordinate,
+                parameters: measurements.map(\.rawValue),
+                start: start,
+                end: end,
+                sources: sources
+            )
+            let requestURL = try XCTUnwrap(request.url)
+            if let previousRequestURL {
+                XCTAssertEqual(requestURL.absoluteString, previousRequestURL.absoluteString)
+            }
+            previousRequestURL = requestURL
+        }
+    }
 }