From 6ffa6647fd54a4e32dcb5babd285d6bdc32ac84f Mon Sep 17 00:00:00 2001 From: Stuart Meeks Date: Sat, 30 May 2026 01:47:50 +0000 Subject: [PATCH] Disable PublishTrimmed for Release until JSON serialisation is trim-safe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The first release run failed with NETSDK1144 (Optimizing assemblies for size failed). Root cause: trimming is on for Release configurations, and three trim issues add up to a build break under TreatWarningsAsErrors: - IL2026 on JsonSerializer.{Deserialize,Serialize}Async in JsonSnipStore and JsonSettingsStore — the reflection-based overloads carry RequiresUnreferencedCodeAttribute. - IL2104 from Jdenticon-net, Microsoft.Windows.SDK.NET, and WinRT.Runtime, which all produce trim warnings of their own. Switching PublishTrimmed off unblocks the release. Re-enabling is captured in TODO.md as the proper follow-up — it wants JsonSerializer to move onto a source-generated JsonSerializerContext plus an audit of the third-party trim warnings. Co-Authored-By: Claude Opus 4.7 --- src/Snipdeck.App/Snipdeck.App.csproj | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/Snipdeck.App/Snipdeck.App.csproj b/src/Snipdeck.App/Snipdeck.App.csproj index 85e1e33..b8030f5 100644 --- a/src/Snipdeck.App/Snipdeck.App.csproj +++ b/src/Snipdeck.App/Snipdeck.App.csproj @@ -45,7 +45,12 @@ False True - False - True + + False