Updated DID:DHT implementation to be compliant with vector 1#504
Merged
thehenrytsai merged 7 commits intomainfrom May 2, 2024
Merged
Updated DID:DHT implementation to be compliant with vector 1#504thehenrytsai merged 7 commits intomainfrom
thehenrytsai merged 7 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 7272955 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-05-01T20:34:13Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 90.56% 90.81% +0.24%
==========================================
Files 112 116 +4
Lines 29117 29414 +297
Branches 2085 2156 +71
==========================================
+ Hits 26370 26711 +341
+ Misses 2712 2668 -44
Partials 35 35
|
nitro-neal
reviewed
May 1, 2024
nitro-neal
reviewed
May 1, 2024
nitro-neal
previously approved these changes
May 1, 2024
diehuxx
reviewed
May 1, 2024
diehuxx
approved these changes
May 1, 2024
diehuxx
left a comment
There was a problem hiding this comment.
looks good! +1 to @nitro-neal's comment, I would love to see the new test vectors added to the web5-spec
nitro-neal
approved these changes
May 1, 2024
csuwildcat
approved these changes
May 2, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.