Added wallet connect options for Web5.connect()#694
Merged
thehenrytsai merged 9 commits intomainfrom Jun 25, 2024
Merged
Conversation
thehenrytsai
requested review from
LiranCohen,
csuwildcat,
diehuxx,
nitro-neal and
shamilovtim
as code owners
🦋 Changeset detectedLatest commit: 27c66a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thehenrytsai
commented
Jun 21, 2024
Contributor
|
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-06-25T17:23:11Z |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
+ Coverage 90.90% 90.92% +0.01%
==========================================
Files 119 119
Lines 30106 30167 +61
Branches 2249 2250 +1
==========================================
+ Hits 27369 27429 +60
- Misses 2702 2703 +1
Partials 35 35
|
thehenrytsai
changed the title
shamilovtim
reviewed
Jun 24, 2024
Contributor
shamilovtim
left a comment
shamilovtim
left a comment
There was a problem hiding this comment.
I think a few changes needed
LiranCohen
previously approved these changes
Jun 24, 2024
Member
LiranCohen
left a comment
LiranCohen
left a comment
There was a problem hiding this comment.
Looks good, but should we include changesets with this PR?
Also remember to create a separate one for api vs the others.
shamilovtim
reviewed
Jun 24, 2024
LiranCohen
previously approved these changes
Jun 24, 2024
shamilovtim
reviewed
Jun 25, 2024
shamilovtim
previously approved these changes
Jun 25, 2024
Contributor
shamilovtim
left a comment
shamilovtim
left a comment
There was a problem hiding this comment.
approving but the workspace:* stuff probably needs to get overwritten by the next release run
thehenrytsai
dismissed stale reviews from shamilovtim and LiranCohen
via
27c66a5
csuwildcat
approved these changes
Jun 25, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dwn-sdk-js(v0.3.10)workspace:*syntax to always keep "agent" dependency in sync to avoid manual updates/mistakes.