From c41a9a49bc5dcc056106e69c36eaf1fc302cfd86 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Sat, 11 Jul 2026 11:08:48 +0900 Subject: [PATCH] test(query-core): assert exact booleans with 'toBe' instead of 'toBeTruthy'/'toBeFalsy' --- .../src/__tests__/focusManager.test.tsx | 4 ++-- .../src/__tests__/onlineManager.test.tsx | 6 ++--- .../query-core/src/__tests__/query.test.tsx | 2 +- .../src/__tests__/queryClient.test.tsx | 24 +++++++++---------- .../query-core/src/__tests__/utils.test.tsx | 10 ++++---- 5 files changed, 23 insertions(+), 23 deletions(-) diff --git a/packages/query-core/src/__tests__/focusManager.test.tsx b/packages/query-core/src/__tests__/focusManager.test.tsx index 03e60d5d7f5..842e1b61ce5 100644 --- a/packages/query-core/src/__tests__/focusManager.test.tsx +++ b/packages/query-core/src/__tests__/focusManager.test.tsx @@ -39,7 +39,7 @@ describe('focusManager', () => { vi.advanceTimersByTime(20) expect(count).toEqual(1) - expect(focusManager.isFocused()).toBeTruthy() + expect(focusManager.isFocused()).toBe(true) }) it('should return true for isFocused if document is undefined', () => { @@ -49,7 +49,7 @@ describe('focusManager', () => { delete globalThis.document focusManager.setFocused() - expect(focusManager.isFocused()).toBeTruthy() + expect(focusManager.isFocused()).toBe(true) globalThis.document = document }) diff --git a/packages/query-core/src/__tests__/onlineManager.test.tsx b/packages/query-core/src/__tests__/onlineManager.test.tsx index d9219e01970..ad726274311 100644 --- a/packages/query-core/src/__tests__/onlineManager.test.tsx +++ b/packages/query-core/src/__tests__/onlineManager.test.tsx @@ -19,7 +19,7 @@ describe('onlineManager', () => { // Force navigator to be undefined // @ts-expect-error navigatorSpy.mockImplementation(() => undefined) - expect(onlineManager.isOnline()).toBeTruthy() + expect(onlineManager.isOnline()).toBe(true) navigatorSpy.mockRestore() }) @@ -28,7 +28,7 @@ describe('onlineManager', () => { const navigatorSpy = vi.spyOn(navigator, 'onLine', 'get') navigatorSpy.mockImplementation(() => true) - expect(onlineManager.isOnline()).toBeTruthy() + expect(onlineManager.isOnline()).toBe(true) navigatorSpy.mockRestore() }) @@ -48,7 +48,7 @@ describe('onlineManager', () => { vi.advanceTimersByTime(20) expect(count).toEqual(1) - expect(onlineManager.isOnline()).toBeFalsy() + expect(onlineManager.isOnline()).toBe(false) }) it('setEventListener should call previous remove handler when replacing an event listener', () => { diff --git a/packages/query-core/src/__tests__/query.test.tsx b/packages/query-core/src/__tests__/query.test.tsx index f097a11ef7d..00caf5704ee 100644 --- a/packages/query-core/src/__tests__/query.test.tsx +++ b/packages/query-core/src/__tests__/query.test.tsx @@ -807,7 +807,7 @@ describe('query', () => { const query = queryCache.find({ queryKey: key })! query.invalidate() - expect(query.state.isInvalidated).toBeTruthy() + expect(query.state.isInvalidated).toBe(true) const previousState = query.state diff --git a/packages/query-core/src/__tests__/queryClient.test.tsx b/packages/query-core/src/__tests__/queryClient.test.tsx index c09db304467..a8db8d10c76 100644 --- a/packages/query-core/src/__tests__/queryClient.test.tsx +++ b/packages/query-core/src/__tests__/queryClient.test.tsx @@ -1781,8 +1781,8 @@ describe('queryClient', () => { void observer1.mutate() void observer2.mutate() - expect(observer1.getCurrentResult().isPaused).toBeTruthy() - expect(observer2.getCurrentResult().isPaused).toBeTruthy() + expect(observer1.getCurrentResult().isPaused).toBe(true) + expect(observer2.getCurrentResult().isPaused).toBe(true) onlineManager.setOnline(true) @@ -1816,8 +1816,8 @@ describe('queryClient', () => { void observer1.mutate() void observer2.mutate() - expect(observer1.getCurrentResult().isPaused).toBeTruthy() - expect(observer2.getCurrentResult().isPaused).toBeTruthy() + expect(observer1.getCurrentResult().isPaused).toBe(true) + expect(observer2.getCurrentResult().isPaused).toBe(true) onlineManager.setOnline(true) @@ -1861,8 +1861,8 @@ describe('queryClient', () => { void observer1.mutate() void observer2.mutate() - expect(observer1.getCurrentResult().isPaused).toBeTruthy() - expect(observer2.getCurrentResult().isPaused).toBeTruthy() + expect(observer1.getCurrentResult().isPaused).toBe(true) + expect(observer2.getCurrentResult().isPaused).toBe(true) onlineManager.setOnline(true) void queryClient.resumePausedMutations() @@ -1885,12 +1885,12 @@ describe('queryClient', () => { void observer.mutate() - expect(observer.getCurrentResult().isPaused).toBeTruthy() + expect(observer.getCurrentResult().isPaused).toBe(true) await queryClient.resumePausedMutations() // still paused because we are still offline - expect(observer.getCurrentResult().isPaused).toBeTruthy() + expect(observer.getCurrentResult().isPaused).toBe(true) onlineManager.setOnline(true) @@ -1909,7 +1909,7 @@ describe('queryClient', () => { void observer.mutate() - expect(observer.getCurrentResult().isPaused).toBeTruthy() + expect(observer.getCurrentResult().isPaused).toBe(true) const state = dehydrate(queryClient) @@ -2004,9 +2004,9 @@ describe('queryClient', () => { void observer3.mutate() - expect(observer.getCurrentResult().isPaused).toBeTruthy() - expect(observer2.getCurrentResult().isPaused).toBeTruthy() - expect(observer3.getCurrentResult().isPaused).toBeTruthy() + expect(observer.getCurrentResult().isPaused).toBe(true) + expect(observer2.getCurrentResult().isPaused).toBe(true) + expect(observer3.getCurrentResult().isPaused).toBe(true) onlineManager.setOnline(true) await vi.advanceTimersByTimeAsync(110) diff --git a/packages/query-core/src/__tests__/utils.test.tsx b/packages/query-core/src/__tests__/utils.test.tsx index 9abd1bf265c..1b102b40d35 100644 --- a/packages/query-core/src/__tests__/utils.test.tsx +++ b/packages/query-core/src/__tests__/utils.test.tsx @@ -79,7 +79,7 @@ describe('core/utils', () => { }) it('should return `true` for object with an undefined constructor', () => { - expect(isPlainObject(Object.create(null))).toBeTruthy() + expect(isPlainObject(Object.create(null))).toBe(true) }) it('should return `false` if constructor does not have an Object-specific method', () => { @@ -89,7 +89,7 @@ describe('core/utils', () => { this.abc = {} } } - expect(isPlainObject(new Foo())).toBeFalsy() + expect(isPlainObject(new Foo())).toBe(false) }) it('should return `false` if the object has a modified prototype', () => { @@ -102,7 +102,7 @@ describe('core/utils', () => { this.vertices.push(v) } - expect(isPlainObject(Object.create(Graph))).toBeFalsy() + expect(isPlainObject(Object.create(Graph))).toBe(false) }) it('should return `false` for object with custom prototype', () => { @@ -110,7 +110,7 @@ describe('core/utils', () => { const obj = Object.create(CustomProto) obj.b = 2 - expect(isPlainObject(obj)).toBeFalsy() + expect(isPlainObject(obj)).toBe(false) }) }) @@ -456,7 +456,7 @@ describe('core/utils', () => { mutationCache: queryClient.getMutationCache(), options: {}, }) - expect(matchMutation(filters, mutation)).toBeFalsy() + expect(matchMutation(filters, mutation)).toBe(false) }) })