Skip to content

Change from only weatherstack to both#10882

Merged
cclauss merged 22 commits intoTheAlgorithms:masterfrom
nababuddin:patch-2
Oct 24, 2023
Merged

Change from only weatherstack to both#10882
cclauss merged 22 commits intoTheAlgorithms:masterfrom
nababuddin:patch-2

Conversation

@nababuddin
Copy link
Contributor

@nababuddin nababuddin commented Oct 24, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@nababuddin nababuddin requested a review from cclauss as a code owner October 24, 2023 07:04
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 24, 2023
nababuddin

This comment was marked as outdated.

Sign in to view

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 24, 2023
nababuddin

This comment was marked as outdated.

Sign in to view

nababuddin
nababuddin commented Oct 24, 2023
View reviewed changes
Copy link
Contributor Author

@nababuddin nababuddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 24, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 24, 2023
@cclauss cclauss changed the title Patch 2 Change from openweathermap to weatherstack Oct 24, 2023
@cclauss
Copy link
Member

cclauss commented Oct 24, 2023 •
edited
Loading

Instead of breaking compatibility with openweathermap, why not create a solution that supports the use of both openweathermap and weatherstack?

@nababuddin
Copy link
Contributor Author

nababuddin commented Oct 24, 2023

Okey I got it thank you

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 24, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 24, 2023
@nababuddin nababuddin changed the title Change from openweathermap to weatherstack Change from only weatherstack to both Oct 24, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 24, 2023
@algorithms-keeper algorithms-keeper bot added the awaiting changes A maintainer has requested changes to this PR label Oct 24, 2023
@cclauss cclauss self-assigned this Oct 24, 2023
cclauss
cclauss reviewed Oct 24, 2023
View reviewed changes
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 24, 2023
nababuddin

This comment was marked as outdated.

Sign in to view

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 24, 2023
nababuddin

This comment was marked as outdated.

Sign in to view

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 24, 2023
nababuddin
nababuddin commented Oct 24, 2023
View reviewed changes
Copy link
Contributor Author

@nababuddin nababuddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done thank you

@nababuddin nababuddin requested a review from cclauss October 24, 2023 12:38
cclauss
cclauss reviewed Oct 24, 2023
View reviewed changes
nababuddin

This comment was marked as outdated.

Sign in to view

nababuddin

This comment was marked as duplicate.

Sign in to view

nababuddin
nababuddin commented Oct 24, 2023
View reviewed changes
Copy link
Contributor Author

@nababuddin nababuddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

cclauss
cclauss approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick!!

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 24, 2023
@cclauss cclauss merged commit a23dd7e into TheAlgorithms:master Oct 24, 2023
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nababuddin @cclauss