Contraband Examine Port (#1350)

## About the PR
This PR adds the system that's going to allow us to mark items as
contraband.
Adding the respective contraband parent to items is going to be for
another pr.

ported:
- space-wizards/space-station-14#28688
- space-wizards/space-station-14#30986
- space-wizards/space-station-14#30930
- space-wizards/space-station-14#30942
- space-wizards/space-station-14#31606
- space-wizards/space-station-14#30970
- space-wizards/space-station-14#33385
- space-wizards/space-station-14#32250
- space-wizards/space-station-14#35206
- space-wizards/space-station-14#35228
- space-wizards/space-station-14#36032

## Why / Balance
It'll allow people to definitely discern whether an item is contraband
or not and what severity.

## Technical details
Look at PR's mentioned.

## Media
(this pr does not actually change these items)
<img width="628" height="165" alt="image"
src="https://github.com/user-attachments/assets/92c7bb4c-0f8f-46cf-9d7f-c9de29a1a473"
/>
<img width="644" height="268" alt="image"
src="https://github.com/user-attachments/assets/053a211c-8f4c-435c-beff-62e3b84a01fe"
/>
<img width="886" height="170" alt="image"
src="https://github.com/user-attachments/assets/09c661aa-b7f8-4e51-bd3d-9110fe22657b"
/>


## Requirements
- [x] I have read and am following the [Pull Request and Changelog
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
- [x] I have added media to this PR or it does not require an ingame
showcase.
- [x] I can confirm this PR contains no AI-generated content, and did
not use any AI-generated content.

## Breaking changes
None as far as I know.

## Changelog
Not needed.

---------

Co-authored-by: Kara <lunarautomaton6@gmail.com>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: Brandon Hu <103440971+Brandon-Huu@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com>
Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com>
Co-authored-by: John <35928781+sporkyz@users.noreply.github.com>
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: Killerqu00 <47712032+Killerqu00@users.noreply.github.com>

Author: 10 people

Content.Client/Examine/ExamineButton.cs

@@ -11,6 +11,7 @@
 using Robust.Client.AutoGenerated;
 using Robust.Client.Graphics;
 using Robust.Client.UserInterface.Controls;
+using Robust.Client.UserInterface.CustomControls;
 using Robust.Client.UserInterface.XAML;
 using Robust.Client.Utility;
 using Robust.Shared.Utility;
@@ -47,7 +48,17 @@ public ExamineButton(ExamineVerb verb)
             Disabled = true;
         }
 
-        ToolTip = verb.Message ?? verb.Text;
+        TooltipSupplier = sender =>
+        {
+            var label = new RichTextLabel();
+            label.SetMessage(FormattedMessage.FromMarkupOrThrow(verb.Message ?? verb.Text));
+
+            var tooltip = new Tooltip();
+            tooltip.GetChild(0).Children.Clear();
+            tooltip.GetChild(0).Children.Add(label);
+
+            return tooltip;
+        };
 
         Icon = new TextureRect
         {

Content.Client/Examine/ExamineSystem.cs

@@ -331,10 +331,28 @@ private void AddVerbsToTooltip(IEnumerable<Verb> verbs)
             {
                 Name = "ExamineButtonsHBox",
                 Orientation = LayoutOrientation.Horizontal,
-                HorizontalAlignment = Control.HAlignment.Right,
+                HorizontalAlignment = Control.HAlignment.Stretch,
                 VerticalAlignment = Control.VAlignment.Bottom,
             };
 
+            var hoverExamineBox = new BoxContainer
+            {
+                Name = "HoverExamineHBox",
+                Orientation = LayoutOrientation.Horizontal,
+                HorizontalAlignment = Control.HAlignment.Left,
+                VerticalAlignment = Control.VAlignment.Center,
+                HorizontalExpand = true
+            };
+
+            var clickExamineBox = new BoxContainer
+            {
+                Name = "ClickExamineHBox",
+                Orientation = LayoutOrientation.Horizontal,
+                HorizontalAlignment = Control.HAlignment.Right,
+                VerticalAlignment = Control.VAlignment.Center,
+                HorizontalExpand = true
+            };
+
             // Examine button time
             foreach (var verb in verbs)
             {
@@ -349,8 +367,15 @@ private void AddVerbsToTooltip(IEnumerable<Verb> verbs)
 
                 var button = new ExamineButton(examine);
 
-                button.OnPressed += VerbButtonPressed;
-                buttonsHBox.AddChild(button);
+                if (examine.HoverVerb)
+                {
+                    hoverExamineBox.AddChild(button);
+                }
+                else
+                {
+                    button.OnPressed += VerbButtonPressed;
+                    clickExamineBox.AddChild(button);
+                }
             }
 
             var vbox = _examineTooltipOpen?.GetChild(0).GetChild(0);
@@ -367,6 +392,8 @@ private void AddVerbsToTooltip(IEnumerable<Verb> verbs)
             {
                 vbox.Children.Remove(hbox.First());
             }
+            buttonsHBox.AddChild(hoverExamineBox);
+            buttonsHBox.AddChild(clickExamineBox);
             vbox.AddChild(buttonsHBox);
         }
 

Content.Client/Verbs/UI/VerbMenuElement.cs

@@ -12,10 +12,12 @@
 using Content.Shared.Verbs;
 using Robust.Client.GameObjects;
 using Robust.Client.UserInterface.Controls;
+using Robust.Client.UserInterface.CustomControls;
 using Robust.Client.Utility;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Maths;
+using Robust.Shared.Utility;
 
 namespace Content.Client.Verbs.UI
 {
@@ -36,7 +38,17 @@ public sealed partial class VerbMenuElement : ContextMenuElement
 
         public VerbMenuElement(Verb verb) : base(verb.Text)
         {
-            ToolTip = verb.Message;
+            TooltipSupplier = sender =>
+            {
+                var label = new RichTextLabel();
+                label.SetMessage(FormattedMessage.FromMarkupOrThrow(verb.Message ?? verb.Text));
+
+                var tooltip = new Tooltip();
+                tooltip.GetChild(0).Children.Clear();
+                tooltip.GetChild(0).Children.Add(label);
+
+                return tooltip;
+            };
             Disabled = verb.Disabled;
             Verb = verb;
 

Content.Client/Verbs/VerbSystem.cs

@@ -233,7 +233,7 @@ public void ExecuteVerb(NetEntity target, Verb verb)
             {
                 // maybe send an informative pop-up message.
                 if (!string.IsNullOrWhiteSpace(verb.Message))
-                    _popupSystem.PopupEntity(verb.Message, user);
+                    _popupSystem.PopupEntity(FormattedMessage.RemoveMarkupOrThrow(verb.Message), user);
 
                 return;
             }

Content.Server/Medical/SuitSensors/SuitSensorSystem.cs

@@ -428,7 +428,7 @@ public void SetSensor(Entity<SuitSensorComponent> sensors, SuitSensorMode mode,
             userJobIcon = card.Comp.JobIcon;
 
             foreach (var department in card.Comp.JobDepartments)
-                userJobDepartments.Add(Loc.GetString(department));
+                userJobDepartments.Add(Loc.GetString($"department-{department}"));
         }
 
         // get health mob state

Content.Server/Verbs/VerbSystem.cs

@@ -34,6 +34,7 @@
 using Content.Shared.Hands.Components;
 using Content.Shared.Inventory.VirtualItem;
 using Content.Shared.Verbs;
+using Robust.Shared.Utility;
 
 namespace Content.Server.Verbs
 {
@@ -102,7 +103,7 @@ public override void ExecuteVerb(Verb verb, EntityUid user, EntityUid target, bo
             {
                 // Send an informative pop-up message
                 if (!string.IsNullOrWhiteSpace(verb.Message))
-                    _popupSystem.PopupEntity(verb.Message, user, user);
+                    _popupSystem.PopupEntity(FormattedMessage.RemoveMarkupOrThrow(verb.Message), user, user);
 
                 return;
             }

Content.Shared/Access/Components/IdCardComponent.cs

@@ -30,6 +30,7 @@
 
 using Content.Shared.Access.Systems;
 using Content.Shared.PDA;
+using Content.Shared.Roles;
 using Content.Shared.StatusIcon;
 using Robust.Shared.GameStates;
 using Robust.Shared.Prototypes;
@@ -51,6 +52,8 @@ public sealed partial class IdCardComponent : Component
     [Access(typeof(SharedIdCardSystem), typeof(SharedPdaSystem), typeof(SharedAgentIdCardSystem), Other = AccessPermissions.ReadWrite)]
     public LocId? JobTitle;
 
+    [DataField]
+    [AutoNetworkedField]
     private string? _jobTitle;
 
     [Access(typeof(SharedIdCardSystem), typeof(SharedPdaSystem), typeof(SharedAgentIdCardSystem), Other = AccessPermissions.ReadWriteExecute)]
@@ -64,11 +67,11 @@ public sealed partial class IdCardComponent : Component
     public ProtoId<JobIconPrototype> JobIcon = "JobIconUnknown";
 
     /// <summary>
-    /// The unlocalized names of the departments associated with the job
+    /// The proto IDs of the departments associated with the job
     /// </summary>
     [DataField]
     [AutoNetworkedField]
-    public List<LocId> JobDepartments = new();
+    public List<ProtoId<DepartmentPrototype>> JobDepartments = new();
 
     /// <summary>
     /// Determines if accesses from this card should be logged by <see cref="AccessReaderComponent"/>

Content.Shared/Access/Systems/SharedIdCardSystem.cs

@@ -185,7 +185,7 @@ public bool TryChangeJobDepartment(EntityUid uid, JobPrototype job, IdCardCompon
         foreach (var department in _prototypeManager.EnumeratePrototypes<DepartmentPrototype>())
         {
             if (department.Roles.Contains(job.ID))
-                id.JobDepartments.Add("department-" + department.ID);
+                id.JobDepartments.Add(department.ID);
         }
 
         Dirty(uid, id);

Content.Shared/CCVar/CCVars.cs

@@ -128,4 +128,10 @@ public sealed partial class CCVars : CVars
     public static readonly CVarDef<bool> GameHostnameInTitlebar =
         CVarDef.Create("game.hostname_in_titlebar", true, CVar.SERVER | CVar.REPLICATED);
 
+    /// <summary>
+    /// If true, contraband severity can be viewed in the examine menu
+    /// </summary>
+    public static readonly CVarDef<bool> ContrabandExamine =
+        CVarDef.Create("game.contraband_examine", true, CVar.SERVER | CVar.REPLICATED);
+
 }

Content.Shared/Clothing/EntitySystems/SharedChameleonClothingSystem.cs

@@ -16,6 +16,7 @@
 
 using Content.Shared.Access.Components;
 using Content.Shared.Clothing.Components;
+using Content.Shared.Contraband;
 using Content.Shared.Inventory;
 using Content.Shared.Inventory.Events;
 using Content.Shared.Item;
@@ -29,6 +30,7 @@ public abstract class SharedChameleonClothingSystem : EntitySystem
     [Dependency] private readonly IComponentFactory _factory = default!;
     [Dependency] private readonly IPrototypeManager _proto = default!;
     [Dependency] private readonly ClothingSystem _clothingSystem = default!;
+    [Dependency] private readonly ContrabandSystem _contraband = default!;
     [Dependency] private readonly MetaDataSystem _metaData = default!;
     [Dependency] private readonly SharedItemSystem _itemSystem = default!;
     [Dependency] private readonly TagSystem _tag = default!;
@@ -84,6 +86,17 @@ protected void UpdateVisuals(EntityUid uid, ChameleonClothingComponent component
         {
             _clothingSystem.CopyVisuals(uid, otherClothing, clothing);
         }
+
+        // properly mark contraband
+        if (proto.TryGetComponent("Contraband", out ContrabandComponent? contra))
+        {
+            EnsureComp<ContrabandComponent>(uid, out var current);
+            _contraband.CopyDetails(uid, contra, current);
+        }
+        else
+        {
+            RemComp<ContrabandComponent>(uid);
+        }
     }
 
     protected virtual void UpdateSprite(EntityUid uid, EntityPrototype proto) { }