Skip to content

Commit 596d821

Browse files
authored
Ignore git-ignored files when glob searching for packages (#55)
1 parent 3c0771d commit 596d821

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

.changeset/tricky-olives-admire.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@manypkg/get-packages": patch
3+
---
4+
5+
Ignore git-ignored files when glob searching for packages. This fixes an issue with package cycles.

packages/get-packages/src/index.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,18 +92,19 @@ export async function getPackages(dir: string): Promise<Packages> {
9292
};
9393
}
9494

95-
const folders = await globby(tool.packageGlobs, {
95+
const directories = await globby(tool.packageGlobs, {
9696
cwd,
9797
onlyDirectories: true,
9898
absolute: true,
99-
expandDirectories: false
99+
expandDirectories: false,
100+
gitignore: true
100101
});
101102

102103
let pkgJsonsMissingNameField: Array<string> = [];
103104

104105
const results = (
105106
await Promise.all(
106-
folders.sort().map(dir =>
107+
directories.sort().map(dir =>
107108
fs
108109
.readJson(path.join(dir, "package.json"))
109110
.then(packageJson => {
@@ -197,16 +198,17 @@ export function getPackagesSync(dir: string): Packages {
197198
packages: [root]
198199
};
199200
}
200-
const folders = globbySync(tool.packageGlobs, {
201+
const directories = globbySync(tool.packageGlobs, {
201202
cwd,
202203
onlyDirectories: true,
203204
absolute: true,
204-
expandDirectories: false
205+
expandDirectories: false,
206+
gitignore: true
205207
});
206208

207209
let pkgJsonsMissingNameField: Array<string> = [];
208210

209-
const results = folders
211+
const results = directories
210212
.sort()
211213
.map(dir => {
212214
try {

0 commit comments

Comments
 (0)