Add stash support and unhide Explorer launches

- Add VCS stash list/create/apply/drop operations through server, contracts, and web RPCs
- Preserve visible Windows Explorer/file-manager launches when process hiding is opted out
- Update tests for the new stash flow and launcher behavior

Author: badcuban

apps/server/src/git/GitWorkflowService.ts

@@ -39,6 +39,14 @@ import {
   type GitPreparePullRequestThreadInput,
   type GitPreparePullRequestThreadResult,
   type GitPullRequestRefInput,
+  type VcsApplyStashInput,
+  type VcsApplyStashResult,
+  type VcsCreateStashInput,
+  type VcsCreateStashResult,
+  type VcsDropStashInput,
+  type VcsDropStashResult,
+  type VcsListStashesInput,
+  type VcsListStashesResult,
   type VcsPullInput,
   type VcsPullResult,
   type VcsRemoveWorktreeInput,
@@ -72,6 +80,18 @@ export interface GitWorkflowServiceShape {
   readonly pullCurrentBranch: (
     input: VcsPullInput,
   ) => Effect.Effect<VcsPullResult, GitCommandError>;
+  readonly listStashes: (
+    input: VcsListStashesInput,
+  ) => Effect.Effect<VcsListStashesResult, GitCommandError>;
+  readonly createStash: (
+    input: VcsCreateStashInput,
+  ) => Effect.Effect<VcsCreateStashResult, GitCommandError>;
+  readonly applyStash: (
+    input: VcsApplyStashInput,
+  ) => Effect.Effect<VcsApplyStashResult, GitCommandError>;
+  readonly dropStash: (
+    input: VcsDropStashInput,
+  ) => Effect.Effect<VcsDropStashResult, GitCommandError>;
   readonly runStackedAction: (
     input: GitRunStackedActionInput,
     options?: GitRunStackedActionOptions,
@@ -354,6 +374,22 @@ export const make = Effect.fn("makeGitWorkflowService")(function* () {
       ensureGitCommand("GitWorkflowService.pullCurrentBranch", input.cwd).pipe(
         Effect.andThen(git.pullCurrentBranch(input)),
       ),
+    listStashes: (input) =>
+      ensureGitCommand("GitWorkflowService.listStashes", input.cwd).pipe(
+        Effect.andThen(git.listStashes(input)),
+      ),
+    createStash: (input) =>
+      ensureGitCommand("GitWorkflowService.createStash", input.cwd).pipe(
+        Effect.andThen(git.createStash(input)),
+      ),
+    applyStash: (input) =>
+      ensureGitCommand("GitWorkflowService.applyStash", input.cwd).pipe(
+        Effect.andThen(git.applyStash(input)),
+      ),
+    dropStash: (input) =>
+      ensureGitCommand("GitWorkflowService.dropStash", input.cwd).pipe(
+        Effect.andThen(git.dropStash(input)),
+      ),
     runStackedAction: (input, options) =>
       ensureGit("GitWorkflowService.runStackedAction", input.cwd).pipe(
         Effect.andThen(gitManager.runStackedAction(input, options)),

apps/server/src/process/externalLauncher.test.ts

@@ -519,6 +519,7 @@ it.layer(NodeServices.layer)("resolveEditorLaunch", (it) => {
         command: "C:\\Windows\\explorer.exe",
         args: [`/select,${filePath}`],
         shell: false,
+        windowsHide: false,
       });
 
       const launch3 = yield* resolveEditorLaunch({ cwd: dir, editor: "file-manager" }, "win32", {
@@ -529,6 +530,7 @@ it.layer(NodeServices.layer)("resolveEditorLaunch", (it) => {
         command: "C:\\Windows\\explorer.exe",
         args: [dir],
         shell: false,
+        windowsHide: false,
       });
 
       const launch4 = yield* resolveEditorLaunch(
@@ -610,6 +612,7 @@ it.layer(NodeServices.layer)("resolveEditorLaunch", (it) => {
         command: "C:\\Windows\\explorer.exe",
         args: [`/select,${filePath}`],
         shell: false,
+        windowsHide: false,
       });
     }),
   );
@@ -631,6 +634,7 @@ it.layer(NodeServices.layer)("resolveEditorLaunch", (it) => {
         command: "C:\\Windows\\explorer.exe",
         args: [dir],
         shell: false,
+        windowsHide: false,
       });
     }),
   );
@@ -776,7 +780,7 @@ it.layer(NodeServices.layer)("launchEditorProcess", (it) => {
     }),
   );
 
-  it.effect("does not wrap args or use a shell when a launch opts out", () =>
+  it.effect("does not wrap args, use a shell, or hide the window when a launch opts out", () =>
     Effect.gen(function* () {
       let spawnedCommand: ChildProcess.StandardCommand | undefined;
       const expectedArgs = ["/select,C:\\workspace\\src\\file.ts"];
@@ -797,22 +801,20 @@ it.layer(NodeServices.layer)("launchEditorProcess", (it) => {
         command: process.execPath,
         args: expectedArgs,
         shell: false,
+        windowsHide: false,
       }).pipe(Effect.provide(spawnerLayer), Effect.result);
 
       assertSuccess(result, undefined);
       assert.ok(spawnedCommand);
       assert.equal(spawnedCommand.command, process.execPath);
       assert.deepEqual(spawnedCommand.args, expectedArgs);
-      assert.deepEqual(
-        spawnedCommand.options,
-        expectedHiddenWindowsOptions({
-          detached: true,
-          shell: false,
-          stdin: "ignore",
-          stdout: "ignore",
-          stderr: "ignore",
-        }),
-      );
+      assert.deepEqual(spawnedCommand.options, {
+        detached: true,
+        shell: false,
+        stdin: "ignore",
+        stdout: "ignore",
+        stderr: "ignore",
+      });
     }),
   );
 

apps/server/src/process/externalLauncher.ts

@@ -35,12 +35,14 @@ interface EditorLaunch {
   readonly command: string;
   readonly args: ReadonlyArray<string>;
   readonly shell?: boolean;
+  readonly windowsHide?: boolean;
 }
 
 interface ProcessLaunch {
   readonly command: string;
   readonly args: ReadonlyArray<string>;
   readonly options: ChildProcess.CommandOptions;
+  readonly windowsHide?: boolean;
 }
 
 interface TargetPathAndPosition {
@@ -241,6 +243,9 @@ const resolveWindowsFileManagerLaunch = Effect.fn("resolveWindowsFileManagerLaun
     command: resolveWindowsExplorerPath(env),
     args,
     shell: false,
+    // `windowsHide` maps to SW_HIDE for GUI processes in libuv. Explorer
+    // starts successfully in that state but never presents its window.
+    windowsHide: false,
   };
 });
 
@@ -400,7 +405,7 @@ const launchAndUnref = Effect.fn("externalLauncher.launchAndUnref")(function* (
   const command = ChildProcess.make(
     launch.command,
     launch.args,
-    hideWindowsConsole(launch.options),
+    launch.windowsHide === false ? launch.options : hideWindowsConsole(launch.options),
   );
 
   yield* spawner.spawn(command).pipe(
@@ -432,13 +437,14 @@ export const launchEditorProcess = Effect.fn("externalLauncher.launchEditorProce
     {
       command: launch.command,
       args: isWin32 && shell ? launch.args.map((arg) => `"${arg}"`) : [...launch.args],
-      options: hideWindowsConsole({
+      options: {
         detached: true,
         shell,
         stdin: "ignore",
         stdout: "ignore",
         stderr: "ignore",
-      }),
+      },
+      ...(launch.windowsHide !== undefined ? { windowsHide: launch.windowsHide } : {}),
     },
     "failed to spawn detached process",
   );

apps/server/src/vcs/GitVcsDriver.ts

@@ -40,6 +40,14 @@ import {
   type VcsListRefsResult,
   type VcsMergeRefInput,
   type VcsMergeRefResult,
+  type VcsApplyStashInput,
+  type VcsApplyStashResult,
+  type VcsCreateStashInput,
+  type VcsCreateStashResult,
+  type VcsDropStashInput,
+  type VcsDropStashResult,
+  type VcsListStashesInput,
+  type VcsListStashesResult,
   type VcsPullInput,
   type VcsPullResult,
   type VcsRemoveWorktreeInput,
@@ -251,6 +259,18 @@ export interface GitVcsDriverShape {
   readonly pullCurrentBranch: (
     input: VcsPullInput,
   ) => Effect.Effect<VcsPullResult, GitCommandError>;
+  readonly listStashes: (
+    input: VcsListStashesInput,
+  ) => Effect.Effect<VcsListStashesResult, GitCommandError>;
+  readonly createStash: (
+    input: VcsCreateStashInput,
+  ) => Effect.Effect<VcsCreateStashResult, GitCommandError>;
+  readonly applyStash: (
+    input: VcsApplyStashInput,
+  ) => Effect.Effect<VcsApplyStashResult, GitCommandError>;
+  readonly dropStash: (
+    input: VcsDropStashInput,
+  ) => Effect.Effect<VcsDropStashResult, GitCommandError>;
   readonly createWorktree: (
     input: VcsCreateWorktreeInput,
   ) => Effect.Effect<VcsCreateWorktreeResult, GitCommandError>;