PR 10.4: remove remaining tool sample dropdowns

Author: DavidQ

docs/operations/dev/codex_commands.md

@@ -1,39 +1,10 @@
 MODEL: GPT-5.3-codex
-REASONING: high
 
 TASK:
-Apply BUILD_PR_LEVEL_10_3_MIGRATE_TOOL_LOCAL_SAMPLES_TO_SAMPLES.
+- scan all tools for sample dropdown/select UI
+- remove them
+- ensure tools still work with manifest input
+- update tests if needed
 
-STEPS:
-1. Read docs/pr/PLAN_PR_LEVEL_10_3_MIGRATE_TOOL_LOCAL_SAMPLES_TO_SAMPLES.md.
-2. Read docs/pr/BUILD_PR_LEVEL_10_3_MIGRATE_TOOL_LOCAL_SAMPLES_TO_SAMPLES.md.
-3. Inspect these tool folders for local samples/demo entries:
-   - tools/Vector Map Editor
-   - tools/Vector Asset Studio
-   - tools/Parallax Scene Studio
-   - tools/Tilemap Studio
-4. Identify each tool-local sample/demo payload.
-5. Move/copy each sample into the correct `samples/phase-*` folder using next available sample IDs.
-6. Preserve sample behavior and required data.
-7. Update `samples/index.html`.
-8. Remove tool-local sample dropdown/select entries from the processed tools after migrated samples exist.
-9. Ensure tools still accept explicit manifest/input data.
-10. Add/update tests for:
-    - migrated sample presence in samples/index.html
-    - migrated sample launch
-    - removal of tool-local sample dropdown/select entries
-11. Write docs/dev/reports/level_10_3_tool_local_sample_migration_report.md.
-12. Update docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md status only if needed:
-    - [ ] -> [.]
-    - [.] -> [x]
-    - no prose rewrite/delete
-13. Do not modify start_of_day.
-14. Do not add validators.
-15. Create Codex delta ZIP:
-    tmp/BUILD_PR_LEVEL_10_3_MIGRATE_TOOL_LOCAL_SAMPLES_TO_SAMPLES_delta.zip
-
-ACCEPTANCE:
-- all discovered tool-local samples from listed tools are migrated
-- samples/index.html updated
-- local sample dropdown/selects removed
-- delta ZIP exists
+OUTPUT:
+tmp/BUILD_PR_LEVEL_10_4_REMOVE_REMAINING_TOOL_SAMPLE_DROPDOWNS_delta.zip

docs/operations/dev/commit_comment.txt

@@ -1,11 +1 @@
-BUILD_PR_LEVEL_10_3_MIGRATE_TOOL_LOCAL_SAMPLES_TO_SAMPLES
-
-- Migrated tool-local samples into /samples
-- Updated samples index
-- Removed local sample dropdown/select entries from processed tools
-- Preserved tool explicit-input behavior
-
-PR Details:
-- Processes Vector Map Editor, Vector Asset Studio, Parallax Scene Studio, and Tilemap Studio
-- No validators
-- No start_of_day changes
+PR 10.4: remove remaining tool sample dropdowns

docs/pr/BUILD_PR_LEVEL_10_4_REMOVE_REMAINING_TOOL_SAMPLE_DROPDOWNS.md

@@ -0,0 +1,6 @@
+Remove any remaining tool-local sample dropdowns across all tools.
+
+Ensure:
+- tools do NOT expose samples internally
+- all samples come from /samples only
+- tools accept manifest-driven input only

tests/tools/ToolLocalSampleMigration.test.mjs

@@ -48,6 +48,49 @@ function assertToolSampleControlsRemoved() {
   assert.equal(parallaxHtml.includes('id="loadSampleButton"'), false, "Parallax Scene Studio sample load button should be removed.");
 }
 
+function listToolIndexFiles(rootPath) {
+  const toolRoot = path.join(rootPath, "tools");
+  const indexFiles = [];
+  const stack = [toolRoot];
+  while (stack.length > 0) {
+    const current = stack.pop();
+    const entries = fs.readdirSync(current, { withFileTypes: true });
+    entries.forEach((entry) => {
+      const fullPath = path.join(current, entry.name);
+      if (entry.isDirectory()) {
+        stack.push(fullPath);
+        return;
+      }
+      if (entry.isFile() && entry.name.toLowerCase() === "index.html") {
+        indexFiles.push(fullPath);
+      }
+    });
+  }
+  return indexFiles;
+}
+
+function assertNoSampleDropdownSelectInToolIndexes() {
+  const indexFiles = listToolIndexFiles(REPO_ROOT);
+  const violations = [];
+
+  indexFiles.forEach((filePath) => {
+    const html = readText(filePath);
+    const hasSampleSelectId = /id\s*=\s*["']sampleSelect["']/i.test(html);
+    const hasSampleSelectTag = /<select\b[^>]*(id|name|class)\s*=\s*["'][^"']*sample[^"']*["'][^>]*>/i.test(html);
+    const hasSamplesLabelSelect = /<label[^>]*>\s*Samples?\b[\s\S]{0,220}<select\b/i.test(html);
+    const hasLegacyNoSamplesCopy = /No samples loaded/i.test(html);
+    if (hasSampleSelectId || hasSampleSelectTag || hasSamplesLabelSelect || hasLegacyNoSamplesCopy) {
+      violations.push(path.relative(REPO_ROOT, filePath).replace(/\\/g, "/"));
+    }
+  });
+
+  assert.equal(
+    violations.length,
+    0,
+    `Tool sample dropdown/select UI residues found in: ${violations.join(", ")}`
+  );
+}
+
 function assertExplicitPresetInputSupportRetained() {
   const vectorMapJs = readText(path.join(REPO_ROOT, "tools", "Vector Map Editor", "editor", "VectorMapEditorApp.js"));
   const vectorAssetJs = readText(path.join(REPO_ROOT, "tools", "Vector Asset Studio", "main.js"));
@@ -103,5 +146,6 @@ function assertMigratedSamplesIndexedAndLaunchable() {
 export function run() {
   assertMigratedSamplesIndexedAndLaunchable();
   assertToolSampleControlsRemoved();
+  assertNoSampleDropdownSelectInToolIndexes();
   assertExplicitPresetInputSupportRetained();
-}
+}

tools/Parallax Scene Studio/main.js

@@ -32,12 +32,8 @@ import { buildEditorExperienceLayer, summarizeEditorExperienceLayer } from "../s
 import { buildDebugVisualizationLayer, summarizeDebugVisualizationLayer } from "../shared/debugVisualizationLayer.js";
 import { registerToolBootContract } from "../shared/toolBootContract.js";
 import { createLivePreviewSyncBridge, validateStateBindingPayload } from "../shared/livePreviewSyncChannel.js";
-import { normalizeToolSamplePath, toToolSampleLabel } from "../shared/toolSampleCatalog.js";
 import { addToolModeMetadata, assertStandaloneToolDocument, offerImportMismatchOptions } from "../shared/documentModeGuards.js";
 
-const SAMPLE_DIRECTORY_PATH = "./samples/";
-const SAMPLE_MANIFEST_PATH = "./samples/sample-manifest.json";
-
 function normalizeSamplePresetPath(pathValue) {
   if (typeof pathValue !== "string") {
     return "";
@@ -384,7 +380,6 @@ class ParallaxEditorApp {
     this.refs = {};
     this.imageCache = new Map();
     this.imageCacheVersion = 0;
-    this.sampleEntries = [];
     this.isSimulationMode = false;
     this.simulation = {
       rafId: 0,
@@ -460,10 +455,6 @@ class ParallaxEditorApp {
     this.renderAll();
     this.bindRuntimeStateSync();
     this.queueLivePreviewSync("init");
-    const hasSamplePresetQuery = new URLSearchParams(window.location.search).has("samplePresetPath");
-    if (this.refs.sampleSelect instanceof HTMLSelectElement && this.refs.loadSampleButton instanceof HTMLButtonElement) {
-      this.loadSampleManifest({ quiet: hasSamplePresetQuery });
-    }
     void this.tryLoadPresetFromQuery();
   }
 
@@ -498,8 +489,6 @@ class ParallaxEditorApp {
     this.refs.mapHeightInput = rootDocument.getElementById("mapHeightInput");
     this.refs.tileSizeInput = rootDocument.getElementById("tileSizeInput");
     this.refs.applyMapMetaButton = rootDocument.getElementById("applyMapMetaButton");
-    this.refs.sampleSelect = rootDocument.getElementById("sampleSelect");
-    this.refs.loadSampleButton = rootDocument.getElementById("loadSampleButton");
 
     this.refs.layerList = rootDocument.getElementById("layerList");
     this.refs.newLayerNameInput = rootDocument.getElementById("newLayerNameInput");
@@ -588,13 +577,6 @@ class ParallaxEditorApp {
 
     this.refs.applyMapMetaButton.addEventListener("click", () => this.applyMapMetaFromInputs());
     this.refs.projectNameInput.addEventListener("change", () => this.applyMapMetaFromInputs());
-    if (this.refs.loadSampleButton instanceof HTMLButtonElement && this.refs.sampleSelect instanceof HTMLSelectElement) {
-      this.refs.loadSampleButton.addEventListener("click", () => this.handleLoadSelectedSample());
-      this.refs.sampleSelect.addEventListener("change", () => this.handleSampleSelectionChanged());
-      this.refs.sampleSelect.addEventListener("focus", () => {
-        void this.loadSampleManifest({ quiet: true });
-      });
-    }
 
     this.refs.addLayerButton.addEventListener("click", () => this.addLayer());
     this.refs.removeLayerButton.addEventListener("click", () => this.removeSelectedLayer());
@@ -989,192 +971,6 @@ class ParallaxEditorApp {
     }
   }
 
-  createSampleEntry(pathValue, labelHint = "", idHint = "") {
-    const path = normalizeToolSamplePath(pathValue);
-    if (!path) {
-      return null;
-    }
-    const normalizedLabel = typeof labelHint === "string" ? labelHint.trim() : "";
-    const fallbackLabel = toToolSampleLabel(path);
-    return {
-      id: typeof idHint === "string" && idHint.trim() ? idHint.trim() : path,
-      label: normalizedLabel && !/[\\/]/.test(normalizedLabel) ? normalizedLabel : fallbackLabel,
-      path
-    };
-  }
-
-  async discoverSampleEntriesFromDirectory() {
-    const directoryUrl = new URL(SAMPLE_DIRECTORY_PATH, window.location.href);
-    const response = await fetch(directoryUrl.toString(), { cache: "no-store" });
-    if (!response.ok) {
-      throw new Error(`Directory request failed (${response.status}).`);
-    }
-
-    const html = await response.text();
-    const parser = new DOMParser();
-    const documentModel = parser.parseFromString(html, "text/html");
-    const anchors = Array.from(documentModel.querySelectorAll("a[href]"));
-    const discovered = [];
-    const seenPaths = new Set();
-
-    anchors.forEach((anchor) => {
-      const href = anchor.getAttribute("href");
-      if (!href) {
-        return;
-      }
-      const resolved = new URL(href, directoryUrl);
-      const fileName = decodeURIComponent((resolved.pathname.split("/").pop() || "").trim());
-      if (!fileName || !fileName.toLowerCase().endsWith(".json")) {
-        return;
-      }
-      if (fileName.toLowerCase() === "sample-manifest.json") {
-        return;
-      }
-
-      const entry = this.createSampleEntry(fileName, anchor.textContent || "", fileName);
-      if (!entry || seenPaths.has(entry.path)) {
-        return;
-      }
-      seenPaths.add(entry.path);
-      discovered.push(entry);
-    });
-
-    discovered.sort((left, right) => left.label.localeCompare(right.label));
-    return discovered;
-  }
-
-  collectSampleEntriesFromManifest(manifest) {
-    const rawSamples = Array.isArray(manifest?.samples) ? manifest.samples : [];
-    return rawSamples
-      .map((entry) => this.createSampleEntry(entry?.path, entry?.label, entry?.id))
-      .filter((entry) => entry !== null);
-  }
-
-  async loadSampleManifest(options = {}) {
-    if (!(this.refs.sampleSelect instanceof HTMLSelectElement) || !(this.refs.loadSampleButton instanceof HTMLButtonElement)) {
-      this.sampleEntries = [];
-      return;
-    }
-    const quiet = options.quiet === true;
-    const previousSelection = normalizeToolSamplePath(this.refs.sampleSelect.value);
-    if (!quiet) {
-      this.refs.sampleSelect.innerHTML = "<option value=\"\">Loading samples...</option>";
-      this.refs.loadSampleButton.disabled = true;
-    }
-
-    try {
-      const sampleEntries = await this.discoverSampleEntriesFromDirectory();
-      if (sampleEntries.length === 0) {
-        throw new Error("No sample JSON files were discovered in ./samples/.");
-      }
-      this.sampleEntries = sampleEntries;
-      this.renderSampleOptions(previousSelection);
-      if (!quiet) {
-        this.updateStatus(`Loaded ${sampleEntries.length} samples from ${SAMPLE_DIRECTORY_PATH}.`);
-      }
-      return;
-    } catch (directoryError) {
-      try {
-        const manifestUrl = new URL(SAMPLE_MANIFEST_PATH, window.location.href);
-        const response = await fetch(manifestUrl.toString(), { cache: "no-store" });
-        if (!response.ok) {
-          throw new Error(`Manifest request failed (${response.status}).`);
-        }
-
-        const manifest = await response.json();
-        const sampleEntries = this.collectSampleEntriesFromManifest(manifest);
-        if (sampleEntries.length === 0) {
-          throw new Error("Sample manifest had no valid entries.");
-        }
-
-        this.sampleEntries = sampleEntries;
-        this.renderSampleOptions(previousSelection);
-        if (!quiet) {
-          this.updateStatus(`Loaded ${sampleEntries.length} samples from ${SAMPLE_MANIFEST_PATH}.`);
-        }
-      } catch (error) {
-        this.sampleEntries = [];
-        this.renderSampleOptions(previousSelection);
-        if (!quiet) {
-          this.updateStatus(`Sample discovery unavailable: ${error instanceof Error ? error.message : "unknown error"}`);
-        }
-      }
-    }
-  }
-
-  renderSampleOptions(preferredPath = "") {
-    if (!(this.refs.sampleSelect instanceof HTMLSelectElement) || !(this.refs.loadSampleButton instanceof HTMLButtonElement)) {
-      return;
-    }
-    const select = this.refs.sampleSelect;
-    select.innerHTML = "";
-
-    if (this.sampleEntries.length === 0) {
-      const option = document.createElement("option");
-      option.value = "";
-      option.textContent = "No samples available";
-      select.appendChild(option);
-      this.refs.loadSampleButton.disabled = true;
-      return;
-    }
-
-    const promptOption = document.createElement("option");
-    promptOption.value = "";
-    promptOption.textContent = "Select a sample...";
-    select.appendChild(promptOption);
-
-    this.sampleEntries.forEach((entry) => {
-      const option = document.createElement("option");
-      option.value = entry.path;
-      option.textContent = entry.label;
-      select.appendChild(option);
-    });
-
-    if (preferredPath && this.sampleEntries.some((entry) => entry.path === preferredPath)) {
-      select.value = preferredPath;
-    }
-    this.refs.loadSampleButton.disabled = false;
-  }
-
-  handleSampleSelectionChanged() {
-    if (!(this.refs.sampleSelect instanceof HTMLSelectElement)) {
-      return;
-    }
-    const selectedPath = normalizeToolSamplePath(this.refs.sampleSelect.value);
-    if (!selectedPath) {
-      return;
-    }
-    this.updateStatus(`Sample selected: ${selectedPath}`);
-  }
-
-  async handleLoadSelectedSample() {
-    if (!(this.refs.sampleSelect instanceof HTMLSelectElement)) {
-      this.updateStatus("Preset loading is available from sample launch context.");
-      return;
-    }
-    const selectedPath = normalizeToolSamplePath(this.refs.sampleSelect.value);
-    if (!selectedPath) {
-      this.updateStatus("Select a sample before loading.");
-      return;
-    }
-
-    this.exitSimulationMode();
-    try {
-      const sampleUrl = new URL(selectedPath, window.location.href);
-      const response = await fetch(sampleUrl.toString(), { cache: "no-store" });
-      if (!response.ok) {
-        throw new Error(`Sample request failed (${response.status}).`);
-      }
-
-      const raw = await response.json();
-      this.applyParallaxDocument(extractParallaxDocument(raw));
-      this.queueLivePreviewSync("load-sample");
-      this.updateStatus(`Loaded sample ${selectedPath}.`);
-    } catch (error) {
-      this.updateStatus(`Sample load failed: ${error instanceof Error ? error.message : "unknown error"}`);
-    }
-  }
-
   async tryLoadPresetFromQuery() {
     const searchParams = new URLSearchParams(window.location.search);
     const samplePresetPath = normalizeSamplePresetPath(searchParams.get("samplePresetPath") || "");

tools/Replay Visualizer/index.html

@@ -23,7 +23,6 @@
         <section class="panel debug-tool-panel">
           <div class="debug-tool-actions">
             <button type="button" id="loadReplayButton">Load Replay JSON</button>
-            <button type="button" id="loadSampleReplayButton">Load Sample Replay</button>
             <button type="button" id="playReplayButton">Play</button>
             <button type="button" id="pauseReplayButton">Pause</button>
             <button type="button" id="resetReplayButton">Reset</button>