Skip to content

Commit 3d5ed9f

Browse files
author
DavidQ
committed
PLAN PR: remaining helper extraction planning (asFiniteNumber, getState).
1 parent 3488d66 commit 3d5ed9f

10 files changed

Lines changed: 177 additions & 11 deletions

‎docs/dev/CODEX_COMMANDS.md‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,11 @@
1-
No Codex command. APPLY only.
1+
MODEL: GPT-5.3-codex
2+
REASONING: high
3+
COMMAND:
4+
Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_04_AS_FINITE_NUMBER_ONLY.md exactly.
5+
Edit only these files:
6+
- src/shared/utils/numberUtils.js
7+
- src/advanced/promotion/createPromotionGate.js
8+
- src/advanced/state/createWorldGameStateSystem.js
9+
- games/network_sample_c/game/ReconciliationLayerAdapter.js
10+
Do not expand scope.
11+
Package the delta output to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_04_AS_FINITE_NUMBER_ONLY_delta.zip

‎docs/dev/COMMIT_COMMENT.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
APPLY PR: import normalization retry accepted for isPlainObject and asPositiveInteger.
1+
BUILD PR: exact asFiniteNumber extraction to shared number utils only.

‎docs/dev/NEXT_COMMAND.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Next: PLAN_PR_SHARED_EXTRACTION_04 (remaining helpers or alias strategy)
1+
Next: if clean, produce APPLY_PR_SHARED_EXTRACTION_04_AS_FINITE_NUMBER_ONLY. If blocked, narrow further without changing PR purpose.

‎docs/dev/reports/change_summary.txt‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
Accepted retry BUILD for import normalization with narrowed scope.
1+
Built an execution-grade BUILD bundle for the remaining helper work by narrowing to one executable helper only: asFiniteNumber.
2+
Excluded getState because the uploaded repo snapshot did not support an exact helper-only extraction map without guessing.

‎docs/dev/reports/file_tree.txt‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,11 @@
1-
docs/pr + docs/dev structure
1+
docs/
2+
pr/
3+
BUILD_PR_SHARED_EXTRACTION_04_AS_FINITE_NUMBER_ONLY.md
4+
dev/
5+
codex_commands.md
6+
commit_comment.txt
7+
next_command.txt
8+
reports/
9+
change_summary.txt
10+
validation_checklist.txt
11+
file_tree.txt

‎docs/dev/reports/validation_checklist.txt‎

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,15 @@
1-
- Only targeted files changed
2-
- Imports point to src/shared
3-
- No additional helpers modified
4-
- Build passes
1+
SESSION VALIDATION GATE
2+
- Bundle type: BUILD
3+
- One PR purpose only: yes
4+
- Exact target files listed: yes
5+
- Exact destination file listed: yes
6+
- Exact source edits listed: yes
7+
- Repo-wide scan avoided: yes
8+
- Start-of-day directories touched: no
9+
- Fake code claims avoided: yes
10+
- ZIP repo-structured and execution-ready: yes
11+
12+
BUILD-SPECIFIC CHECKS
13+
- Codex can execute without guessing: yes
14+
- Scope minimized to one helper: yes
15+
- Non-goals explicit: yes

‎docs/pr/BUILD_PR_SHARED_EXTRACTION_04_AS_FINITE_NUMBER_ONLY.md‎

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
# BUILD_PR_SHARED_EXTRACTION_04_AS_FINITE_NUMBER_ONLY
2+
3+
## Purpose
4+
Extract and normalize `asFiniteNumber` only.
5+
6+
This BUILD intentionally narrows scope to one executable helper move so the bundle can execute code directly without guessing.
7+
8+
## Single PR Purpose
9+
- move duplicate `asFiniteNumber` implementations into the existing shared number helper module
10+
- update only the exact imports/call sites affected by that move
11+
12+
## Exact Source Files
13+
1. `src/advanced/promotion/createPromotionGate.js`
14+
2. `src/advanced/state/createWorldGameStateSystem.js`
15+
3. `games/network_sample_c/game/ReconciliationLayerAdapter.js`
16+
17+
## Exact Destination File
18+
- `src/shared/utils/numberUtils.js`
19+
20+
## Exact Move Rules
21+
### Destination ownership
22+
`src/shared/utils/numberUtils.js` must export:
23+
- `asFiniteNumber`
24+
- preserve existing exports already in that file
25+
- do not rename `asFiniteNumber`
26+
27+
### Source edits
28+
#### 1) `src/advanced/promotion/createPromotionGate.js`
29+
- remove the local `asFiniteNumber` function definition
30+
- keep the local `asPositiveInteger` function as-is
31+
- add an import for `asFiniteNumber` from:
32+
- `../../shared/utils/numberUtils.js`
33+
34+
#### 2) `src/advanced/state/createWorldGameStateSystem.js`
35+
- remove the local `asFiniteNumber` function definition
36+
- keep the local `asPositiveInteger` function as-is
37+
- add an import for `asFiniteNumber` from:
38+
- `../../shared/utils/numberUtils.js`
39+
40+
#### 3) `games/network_sample_c/game/ReconciliationLayerAdapter.js`
41+
- remove the local `asFiniteNumber` function definition
42+
- add an import for `asFiniteNumber` from:
43+
- `../../../src/shared/utils/numberUtils.js`
44+
45+
## Hard Constraints
46+
- edit only the 4 files listed in this BUILD:
47+
- `src/shared/utils/numberUtils.js`
48+
- `src/advanced/promotion/createPromotionGate.js`
49+
- `src/advanced/state/createWorldGameStateSystem.js`
50+
- `games/network_sample_c/game/ReconciliationLayerAdapter.js`
51+
- do not change logic
52+
- do not move any other helper
53+
- do not modify engine APIs
54+
- do not normalize `getState` in this PR
55+
- do not touch `asPositiveInteger` in this PR except preserving existing local usage in the two advanced files
56+
- do not perform repo-wide cleanup
57+
58+
## Validation Checklist
59+
1. Confirm only the 4 listed files changed
60+
2. Confirm `asFiniteNumber` is exported from `src/shared/utils/numberUtils.js`
61+
3. Confirm `asFiniteNumber` local definitions no longer exist in:
62+
- `src/advanced/promotion/createPromotionGate.js`
63+
- `src/advanced/state/createWorldGameStateSystem.js`
64+
- `games/network_sample_c/game/ReconciliationLayerAdapter.js`
65+
4. Confirm imports now point to:
66+
- `../../shared/utils/numberUtils.js`
67+
- `../../../src/shared/utils/numberUtils.js`
68+
5. Confirm no logic/runtime behavior changes were introduced
69+
6. Confirm no `getState` work was performed
70+
71+
## Non-Goals
72+
- no `getState` extraction
73+
- no import normalization beyond `asFiniteNumber`
74+
- no alias path migration
75+
- no refactor
76+
- no file creation beyond using the existing `src/shared/utils/numberUtils.js`

‎docs/pr/PLAN_PR_SHARED_EXTRACTION_04_REMAINING_HELPERS.md‎

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
# PLAN_PR_SHARED_EXTRACTION_04_REMAINING_HELPERS
2+
3+
## Purpose
4+
Plan extraction + normalization for remaining helpers not yet centralized:
5+
- asFiniteNumber
6+
- getState (non-shared + widespread usage)
7+
8+
## Scope
9+
- Identify explicit targets for remaining helpers
10+
- Define exact source → destination mapping
11+
- Define exact import update targets
12+
13+
## Constraints
14+
- No repo-wide guessing
15+
- No execution in this PR
16+
- One purpose only
17+
18+
## Required Outputs (next BUILD readiness)
19+
Must produce:
20+
1. Exact source file list
21+
2. Exact destination files
22+
3. Exact helper mappings
23+
4. Exact import update targets
24+
25+
## Strategy
26+
27+
### Phase 1: asFiniteNumber
28+
- Consolidate to:
29+
src/shared/utils/numberUtils.js
30+
- Identify all consumers explicitly
31+
32+
### Phase 2: getState
33+
- Split into:
34+
src/shared/state/getState.js (shared-safe version)
35+
- DO NOT touch engine-specific state accessors
36+
37+
## Acceptance Criteria
38+
- All targets explicitly listed
39+
- No ambiguity remains for BUILD
40+
- No guessing required
41+
42+
## Non-Goals
43+
- No code changes
44+
- No file movement
45+
- No import updates
46+
47+
## Next
48+
BUILD_PR_SHARED_EXTRACTION_04_REMAINING_HELPERS

‎src/advanced/promotion/createPromotionGate.js‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,14 @@ David Quesenberry
55
createPromotionGate.js
66
*/
77

8-
import { asFiniteNumber, asPositiveInteger } from '../../shared/utils/numberUtils.js';
8+
import { asFiniteNumber } from '../../shared/utils/numberUtils.js';
99
import { isPlainObject } from '../../shared/utils/objectUtils.js';
1010

11+
function asPositiveInteger(value, fallback = 1) {
12+
const numeric = Math.floor(asFiniteNumber(value, fallback));
13+
return numeric >= 1 ? numeric : fallback;
14+
}
15+
1116
function normalizeCriteriaMap(input, requiredCriteria = []) {
1217
const normalized = {};
1318
if (isPlainObject(input)) {

‎src/advanced/state/createWorldGameStateSystem.js‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {
1919
createTransitionRejectedEvent
2020
} from './events.js';
2121
import { getState as getSharedState } from '../../shared/state/getState.js';
22-
import { asPositiveInteger } from '../../shared/utils/numberUtils.js';
22+
import { asFiniteNumber } from '../../shared/utils/numberUtils.js';
2323
import {
2424
cloneDeep,
2525
createReadonlyClone,
@@ -78,6 +78,11 @@ function resolveFrameFromMeta(meta, payload) {
7878
return null;
7979
}
8080

81+
function asPositiveInteger(value, fallback = 1) {
82+
const numeric = Math.floor(asFiniteNumber(value, fallback));
83+
return numeric >= 1 ? numeric : fallback;
84+
}
85+
8186
function normalizeRequiredCriteria(requiredCriteria) {
8287
if (!Array.isArray(requiredCriteria)) return [];
8388
const seen = new Set();

0 commit comments

Comments
 (0)