Skip to content

Commit a49176f

Browse files
author
DavidQ
committed
Apply Sample A server containerization artifacts and finalize Track U checklist states without engine-core changes.
1 parent aaa51cc commit a49176f

7 files changed

Lines changed: 130 additions & 280 deletions

docs/dev/CODEX_COMMANDS.md

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,15 @@ MODEL: GPT-5.4-codex
22
REASONING: high
33

44
COMMAND:
5-
Create BUILD_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION
5+
Create APPLY_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION
66

77
Requirements:
8-
- Follow PLAN_PR + BUILD_PR + APPLY_PR
9-
- This is code/runtime work, not documentation-only work
10-
- Use the BUILD doc as the exact blueprint
11-
- One PR per purpose
8+
- This is acceptance/finalization work after the BUILD step already wrote code
9+
- Do not broaden scope
10+
- Keep Sample A server containerization only
1211
- No engine core changes
13-
- Keep scope to Sample A server containerization only
14-
- Create/update:
15-
- games/network_sample_a/server/Dockerfile
16-
- games/network_sample_a/.dockerignore
17-
- games/network_sample_a/server/docker-compose.yml
18-
- games/network_sample_a/server/README.md
19-
- games/network_sample_a/server/networkSampleADashboardServer.mjs only if required for env-safe host/access compatibility
12+
- Confirm code artifacts exist and validate them
2013
- Update docs/roadmaps/NETWORK_SAMPLES_PLAN.md with bracket-only edits only
2114
- Do not overwrite BIG_PICTURE_ROADMAP.md
2215
- Do not overwrite PRODUCTIZATION_ROADMAP.md
23-
- Package repo-structured delta zip to <project folder>/tmp/BUILD_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION_delta.zip
16+
- Package repo-structured delta zip to <project folder>/tmp/APPLY_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION_delta.zip

docs/dev/COMMIT_COMMENT.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Build Sample A server containerization artifacts and update Track U roadmap states without engine-core changes.
1+
Apply Sample A server containerization artifacts and finalize Track U checklist states without engine-core changes.

docs/dev/NEXT_COMMAND.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
APPLY_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION
1+
PLAN_PR_DEBUG_SURFACES_SERVER_RUNTIME_ISOLATION
Lines changed: 19 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,25 @@
11
# Change Summary
22

33
## Bundle
4-
BUILD_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION_delta
4+
APPLY_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION_delta
55

6-
## Runtime Work Applied
7-
- Updated `games/network_sample_a/.dockerignore` to a strict allowlist pattern aligned with Dockerfile copy paths.
8-
- Updated `games/network_sample_a/server/README.md` with explicit stdout/stderr-only logging expectation.
9-
- Kept existing Sample A server runtime/container files aligned to the BUILD blueprint without broad refactors.
6+
## Intent
7+
Docs-only APPLY bundle for accepting and finalizing the already-completed Codex server containerization build.
108

11-
## Roadmap Update (Bracket-Only)
12-
- `docs/roadmaps/NETWORK_SAMPLES_PLAN.md` Track U items set to `[x]`:
13-
- Dockerfile for server
14-
- .dockerignore
15-
- Environment variable contract
16-
- Local run command
17-
- Compose-ready service definition
18-
- Port mapping rules
19-
- Health/readiness check
20-
- Logging/output expectations
21-
- Container debug notes
9+
## Acceptance Validation
10+
- Confirmed artifact presence:
11+
- `games/network_sample_a/server/Dockerfile`
12+
- `games/network_sample_a/.dockerignore`
13+
- `games/network_sample_a/server/docker-compose.yml`
14+
- `games/network_sample_a/server/README.md`
15+
- `games/network_sample_a/server/networkSampleADashboardServer.mjs`
16+
- Required check passed:
17+
- `node --check games/network_sample_a/server/networkSampleADashboardServer.mjs`
18+
- Docker CLI is unavailable in this environment, so image build/compose runtime checks could not be executed here.
2219

23-
## Guardrails Confirmed
24-
- No engine core changes
25-
- Scope limited to Sample A server containerization
26-
- No overwrite of `BIG_PICTURE_ROADMAP.md`
27-
- No overwrite of `PRODUCTIZATION_ROADMAP.md`
28-
29-
## Validation Highlights
30-
- `node --check games/network_sample_a/server/networkSampleADashboardServer.mjs` passed.
31-
- Local smoke run passed:
32-
- `/admin/network-sample-a/health` returned 200
33-
- `/admin/network-sample-a/api/metrics?key=sample-a-admin` returned 200
34-
- unauthenticated `/admin/network-sample-a/api/metrics` returned 403
35-
- Docker CLI is unavailable in this environment, so image build validation could not be executed here.
20+
## Scope And Roadmap
21+
- Scope stayed on Sample A server containerization acceptance/finalization only.
22+
- No engine/core files were modified in this APPLY working delta.
23+
- `docs/roadmaps/NETWORK_SAMPLES_PLAN.md` Track U checklist states are complete (`[x]`) and remain bracket-only.
24+
- `docs/roadmaps/BIG_PICTURE_ROADMAP.md` was not overwritten.
25+
- `docs/roadmaps/PRODUCTIZATION_ROADMAP.md` was not overwritten.
Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,17 @@
11
# Validation Checklist
22

3-
- [x] BUILD doc present
43
- [x] APPLY doc present
4+
- [x] Companion BUILD doc present
55
- [x] Codex command present
66
- [x] Commit comment present
77
- [x] Next command present
8-
- [x] BUILD doc provides exact Dockerfile blueprint
9-
- [x] BUILD doc provides exact compose blueprint
10-
- [x] BUILD doc provides exact env contract
11-
- [x] BUILD doc limits scope to Sample A server containerization
12-
- [x] `node --check games/network_sample_a/server/networkSampleADashboardServer.mjs` passed
13-
- [x] Local smoke run passed (`/health` 200, `/api/metrics?key=...` 200, unauthenticated metrics 403)
14-
- [x] Dockerfile contract verified (Node 22 Alpine, port 4310, healthcheck path)
15-
- [x] Compose contract verified (port map, env vars, healthcheck, restart policy)
16-
- [x] `.dockerignore` constrains context to required files
17-
- [x] README includes build/run/compose/health/env/logging guidance
18-
- [x] `NETWORK_SAMPLES_PLAN.md` Track U updated with bracket-only edits
19-
- [x] `BIG_PICTURE_ROADMAP.md` not overwritten in this pass
20-
- [x] `PRODUCTIZATION_ROADMAP.md` not overwritten in this pass
21-
- [ ] Docker image build validation (Docker CLI unavailable in this environment)
8+
- [x] Dockerfile exists
9+
- [x] .dockerignore exists
10+
- [x] docker-compose.yml exists
11+
- [x] README exists
12+
- [x] `node --check games/network_sample_a/server/networkSampleADashboardServer.mjs` passes
13+
- [x] Docker validation documented as unavailable in this environment (`docker` CLI not installed)
14+
- [x] No engine-core changes in this APPLY working delta
15+
- [x] NETWORK_SAMPLES_PLAN Track U bracket states verified complete (`[x]`)
16+
- [x] BIG_PICTURE_ROADMAP preserved
17+
- [x] PRODUCTIZATION_ROADMAP preserved

docs/pr/APPLY_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION.md

Lines changed: 87 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -6,38 +6,95 @@ APPLY_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION.md
66
# APPLY_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION
77

88
## Apply Intent
9-
Apply the minimal Sample A server containerization defined by the BUILD doc.
10-
This APPLY step is code/runtime work for Codex, not documentation work for ChatGPT.
9+
This is a docs-only APPLY bundle for the completed Codex build/output.
10+
Use it to confirm acceptance, validate scope, and finalize the PR cleanly.
11+
12+
## Boundary
13+
- ChatGPT did not write code here.
14+
- Codex already produced the code/runtime delta bundle.
15+
- This APPLY doc is for acceptance, validation, commit discipline, and tracker finalization only.
16+
17+
## Expected Codex Outputs
18+
The completed build should already contain code/runtime artifacts for:
1119

12-
## In Scope Files
1320
- `games/network_sample_a/server/Dockerfile`
1421
- `games/network_sample_a/.dockerignore`
1522
- `games/network_sample_a/server/docker-compose.yml`
1623
- `games/network_sample_a/server/README.md`
17-
- `games/network_sample_a/server/networkSampleADashboardServer.mjs` only if required for env-safe host/access compatibility
18-
- `docs/pr/BUILD_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION.md`
19-
- `docs/pr/APPLY_PR_DEBUG_SURFACES_SERVER_CONTAINERIZATION.md`
20-
- `docs/dev/codex_commands.md`
21-
- `docs/dev/commit_comment.txt`
22-
- `docs/dev/next_command.txt`
23-
- `docs/dev/reports/change_summary.txt`
24-
- `docs/dev/reports/file_tree.txt`
25-
- `docs/dev/reports/validation_checklist.txt`
26-
- `docs/roadmaps/NETWORK_SAMPLES_PLAN.md` with bracket-only edits only
27-
28-
## Hard Rules
29-
- no engine-core changes
30-
- no dashboard mutation features
31-
- no auth redesign
32-
- no orchestration stack
33-
- no unrelated runtime refactors
34-
- no placeholder docs
35-
- no roadmap structure changes
36-
37-
## Acceptance
38-
- Dockerfile builds Sample A dashboard server image
39-
- compose file runs the same service contract
40-
- env vars are documented and honored
41-
- health route works
42-
- README is actionable
43-
- roadmap Track U items update by bracket-only edits
24+
- `games/network_sample_a/server/networkSampleADashboardServer.mjs` only if required for env-safe host/access support
25+
26+
## Acceptance Criteria
27+
Accept this PR only if all of the following are true:
28+
29+
### Container Artifacts
30+
- Dockerfile exists under `games/network_sample_a/server/`
31+
- `.dockerignore` exists under `games/network_sample_a/`
32+
- compose file exists under `games/network_sample_a/server/`
33+
- README exists under `games/network_sample_a/server/`
34+
35+
### Scope Control
36+
- no engine/core files changed
37+
- no dashboard mutation/admin features added
38+
- no transport redesign occurred
39+
- no unrelated sample/game refactors occurred
40+
41+
### Runtime Contract
42+
- container targets the existing Sample A dashboard server runtime
43+
- host/port/env usage matches the BUILD blueprint
44+
- health route remains:
45+
- `/admin/network-sample-a/health`
46+
- container port contract remains:
47+
- `4310`
48+
49+
### Documentation Contract
50+
README should contain:
51+
- docker build command
52+
- docker run command
53+
- compose command
54+
- mapped port explanation
55+
- health URL
56+
- env var meanings
57+
- logging expectation (stdout/stderr only)
58+
59+
## Required Validation
60+
### Required checks
61+
- `node --check games/network_sample_a/server/networkSampleADashboardServer.mjs`
62+
63+
### If Docker is available
64+
- `docker build -f games/network_sample_a/server/Dockerfile games/network_sample_a -t network-sample-a-dashboard`
65+
- `docker compose -f games/network_sample_a/server/docker-compose.yml up --build`
66+
- verify:
67+
- health route responds
68+
- mapped port is correct
69+
- container starts without extra runtime changes
70+
71+
## Roadmap Finalization Rule
72+
Only update bracket states.
73+
Do not change wording, ordering, headings, or structure.
74+
75+
### docs/roadmaps/NETWORK_SAMPLES_PLAN.md
76+
Set these to `[x]` if Codex output satisfies acceptance:
77+
- `Dockerfile for server`
78+
- `.dockerignore`
79+
- `Environment variable contract`
80+
- `Local run command`
81+
- `Compose-ready service definition`
82+
- `Port mapping rules`
83+
- `Health/readiness check`
84+
- `Logging/output expectations`
85+
- `Container debug notes`
86+
87+
### docs/roadmaps/BIG_PICTURE_ROADMAP.md
88+
No changes unless there is an existing exact matching item that only needs a bracket-state change.
89+
90+
### docs/roadmaps/PRODUCTIZATION_ROADMAP.md
91+
No changes in this PR.
92+
93+
## Commit Guidance
94+
Commit only after:
95+
- code/runtime outputs are present
96+
- validation passes or acceptable validation notes are documented
97+
- roadmap bracket states are updated surgically only
98+
99+
## Recommended Commit Comment
100+
Apply Sample A server containerization artifacts and finalize Track U checklist states without engine-core changes.

0 commit comments

Comments
 (0)