Skip to content

fix(eda): keep event naming skill focused - #58

Merged
yordis merged 1 commit into
mainfrom
yordis/fix-eda-progressive-disclosure
May 26, 2026
Merged

fix(eda): keep event naming skill focused#58
yordis merged 1 commit into
mainfrom
yordis/fix-eda-progressive-disclosure

Conversation

@yordis

@yordis yordis commented May 26, 2026

Copy link
Copy Markdown
Member
  • Event naming guidance needs to stay lightweight enough for agents to load by default.
  • Detailed examples and criteria still need to be discoverable when reviews touch naming edge cases, field placement, stream identity, or pass/fail quality gates.

@cursor

cursor Bot commented May 26, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation-only reorganization of agent skill markdown; no application runtime or API behavior changes.

Overview
The event-name agent skill is refactored so the default load stays small: SKILL.md now states core principles, numbered rules, a five-item quality gate, and when to pull deeper material, instead of embedding long tables and a 30-point checklist.

Detailed guidance moves into four references/ files—event naming examples, field naming examples, record/stream/event_type boundaries, and the full pass/fail checklist—linked via a Progressive disclosure section and per-topic “read when needed” pointers. Review output still expects pass/fail against the full checklist when agents open quality-checklist.md.

Reviewed by Cursor Bugbot for commit 5499fc9. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yordis, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 14 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bac2d4e1-a275-4d0d-ba3c-816fac133251

📥 Commits

Reviewing files that changed from the base of the PR and between f6e8d20 and 5499fc9.

📒 Files selected for processing (5)
  • plugins/trogonstack-eda/skills/event-name/SKILL.md
  • plugins/trogonstack-eda/skills/event-name/references/event-naming-rules.md
  • plugins/trogonstack-eda/skills/event-name/references/event-record-boundaries.md
  • plugins/trogonstack-eda/skills/event-name/references/field-naming-rules.md
  • plugins/trogonstack-eda/skills/event-name/references/quality-checklist.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/fix-eda-progressive-disclosure

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yordis
yordis force-pushed the yordis/fix-eda-progressive-disclosure branch from bb9108c to 6967ce1 Compare May 26, 2026 05:31
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/fix-eda-progressive-disclosure branch from 6967ce1 to 5499fc9 Compare May 26, 2026 05:35
@yordis
yordis merged commit df69a96 into main May 26, 2026
5 checks passed
@yordis
yordis deleted the yordis/fix-eda-progressive-disclosure branch May 26, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant