Skip to content

Commit 67dc363

Browse files
committed
Improved readability of check for stripeCustomer
1 parent 9c5d67f commit 67dc363

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

ghost/core/core/server/services/members/members-api/repositories/MemberRepository.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,8 @@ module.exports = class MemberRepository {
347347
if (config.get('memberWelcomeEmailTestInbox') && WELCOME_EMAIL_SOURCES.includes(source)) {
348348
const freeWelcomeEmail = this._AutomatedEmail ? await this._AutomatedEmail.findOne({slug: MEMBER_WELCOME_EMAIL_SLUGS.free}) : null;
349349
const isFreeWelcomeEmailActive = freeWelcomeEmail && freeWelcomeEmail.get('lexical') && freeWelcomeEmail.get('status') === 'active';
350-
350+
const isFreeSignup = !stripeCustomer;
351+
351352
const runMemberCreation = async (transacting) => {
352353
const newMember = await this._Member.add({
353354
...memberData,
@@ -358,7 +359,7 @@ module.exports = class MemberRepository {
358359
// Only send the free welcome email if:
359360
// 1. The free welcome email is active
360361
// 2. The member is not signing up for a paid subscription (no stripeCustomer)
361-
if (isFreeWelcomeEmailActive && !stripeCustomer) {
362+
if (isFreeWelcomeEmailActive && isFreeSignup) {
362363
const timestamp = eventData.created_at || newMember.get('created_at');
363364

364365
await this._Outbox.add({
@@ -384,7 +385,7 @@ module.exports = class MemberRepository {
384385
member = await this._Member.transaction(runMemberCreation);
385386
}
386387

387-
if (isFreeWelcomeEmailActive && !stripeCustomer) {
388+
if (isFreeWelcomeEmailActive && isFreeSignup) {
388389
this.dispatchEvent(StartOutboxProcessingEvent.create({memberId: member.id}), memberAddOptions);
389390
}
390391
} else {

0 commit comments

Comments
 (0)