Hotfix add all locations to colorbar label #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #294 by ensuring that the colorbar label placement accommodates all valid location combinations. Key changes include:
- Adding parameterized tests in ultraplot/tests/test_colorbar.py to verify label placement across various combinations.
- Refactoring the label placement logic in ultraplot/axes/base.py using helper functions for improved clarity and maintainability.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ultraplot/tests/test_colorbar.py | Added new tests to cover diverse colorbar and label positions. |
| ultraplot/axes/base.py | Refactored the colorbar label placement logic with helper functions. |
cvanelteren
added a commit
that referenced
this pull request
Aug 14, 2025
* fix label pos * updated unittest * make test extremely dumb * going overkill with tests * relabel test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #294