Fix edge case where vcenter is not properly set for diverging norms #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Note that vcenter is the data value for which the space is exactly half. The PR currently infers it only if |
Collaborator
Author
|
Actually I move it to |
beckermr
approved these changes
Aug 7, 2025
beckermr
approved these changes
Aug 7, 2025
cvanelteren
added a commit
that referenced
this pull request
Aug 14, 2025
…314) * add unittest * add to parse cmap * replace unittest with becker's example * restore init of diverging norm * fix import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #313
Not sure if this is the best way to approach this. The issue in #313 is caused by the vcenter being 0 where the data is clearly not zerod around that value. I would prefer to push this code in the parsing of cmap directly inferring it from the input data when set, but the current colorbar handling is still rather opague to me. I wanted to move it to a separate class and clean it up but there seems that task proven to be more challenging than I initially thought. Open for feedback to fix this is another way.
Basically, the vcenter is now inferred if vmin and vmax is set, otherwise defaults to normal default vcenter = 0.