Skip to content

Conversation

@cvanelteren
Copy link
Collaborator

This PR would introduce a version check to inform users if a newer version of the package is available.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ultraplot/__init__.py 33.33% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@cvanelteren cvanelteren requested a review from beckermr October 22, 2025 06:47
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find these kinds of features a bit spammy except for cases like package managers etc. I'd prefer the default to be False so this is off unless someone really wants it.

@cvanelteren
Copy link
Collaborator Author

Hmm ok I hear you. The uptick for the more recent versions is not as high as the previous ones. I thought nudging people to upgrade would be a good idea. We could leave it out and put it in the refs indeed; do agree that package managers should handle this. Will think about it a bit and otherwise close this.

@cvanelteren cvanelteren merged commit cd4f876 into Ultraplot:main Oct 25, 2025
2 of 4 checks passed
@cvanelteren
Copy link
Collaborator Author

Turned the default to off and added some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants