[utbot-rider]

bug fix

Author: Domonion

build.gradle.kts

@@ -53,6 +53,8 @@ allprojects {
             }
         }
         withType<Test> {
+            testLogging.showStandardStreams = true
+            testLogging.showStackTraces = true
             // set heap size for the test JVM(s)
             minHeapSize = "128m"
             maxHeapSize = "3072m"
@@ -68,6 +70,9 @@ allprojects {
                 override fun beforeTest(testDescriptor: TestDescriptor) {}
                 override fun afterTest(testDescriptor: TestDescriptor, result: TestResult) {
                     println("[$testDescriptor.classDisplayName] [$testDescriptor.displayName]: $result.resultType, length - ${(result.endTime - result.startTime) / 1000.0} sec")
+                    if (result.resultType == org.gradle.api.tasks.testing.TestResult.ResultType.FAILURE) {
+                        println("Exception: " + result.exception?.stackTraceToString())
+                    }
                 }
 
                 override fun afterSuite(testDescriptor: TestDescriptor, result: TestResult) {

utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/Api.kt

@@ -215,8 +215,16 @@ class UtFailedExecution(
 open class EnvironmentModels(
     val thisInstance: UtModel?,
     val parameters: List<UtModel>,
-    val statics: Map<FieldId, UtModel>
+    val statics: Map<FieldId, UtModel>,
+    fromMissingState: Boolean
 ) {
+    constructor(thisInstance: UtModel?, parameters: List<UtModel>, statics: Map<FieldId, UtModel>): this(thisInstance, parameters, statics, false)
+
+    init {
+        if (!fromMissingState && thisInstance == null && parameters.isEmpty() && statics.isEmpty()) {
+            Exception("something is bad, constructing huawei models").printStackTrace()
+        }
+    }
     override fun toString() = buildString {
         append("this=$thisInstance")
         appendOptional("parameters", parameters)
@@ -234,8 +242,13 @@ open class EnvironmentModels(
 object MissingState : EnvironmentModels(
     thisInstance = null,
     parameters = emptyList(),
-    statics = emptyMap()
-)
+    statics = emptyMap(),
+    fromMissingState = true
+) {
+    override fun toString(): String {
+        return "missing state"
+    }
+}
 
 /**
  * Error happened in traverse.

utbot-framework/src/main/kotlin/org/utbot/engine/Traverser.kt

@@ -7,6 +7,7 @@ import kotlinx.collections.immutable.persistentSetOf
 import kotlinx.collections.immutable.toPersistentList
 import kotlinx.collections.immutable.toPersistentMap
 import kotlinx.collections.immutable.toPersistentSet
+import mu.KotlinLogging
 import org.utbot.common.WorkaroundReason.HACK
 import org.utbot.framework.UtSettings.ignoreStaticsFromTrustedLibraries
 import org.utbot.common.WorkaroundReason.IGNORE_STATICS_FROM_TRUSTED_LIBRARIES
@@ -224,6 +225,7 @@ import java.lang.reflect.TypeVariable
 import java.lang.reflect.WildcardType
 
 private val CAUGHT_EXCEPTION = LocalVariable("@caughtexception")
+private val logger = KotlinLogging.logger {}
 
 class Traverser(
     private val methodUnderTest: ExecutableId,

utbot-framework/src/main/kotlin/org/utbot/engine/UtBotSymbolicEngine.kt

@@ -51,7 +51,7 @@ import java.lang.reflect.Method
 import kotlin.math.min
 import kotlin.system.measureTimeMillis
 
-val logger = KotlinLogging.logger {}
+private val logger = KotlinLogging.logger {}
 val pathLogger = KotlinLogging.logger(logger.name + ".path")
 
 //in future we should put all timeouts here

utbot-framework/src/main/kotlin/org/utbot/framework/util/EngineUtils.kt

@@ -1,5 +1,7 @@
 package org.utbot.framework.util
 
+import mu.KotlinLogging
+import org.utbot.common.logException
 import org.utbot.framework.plugin.api.util.constructor.ValueConstructor
 import org.utbot.framework.plugin.api.ExecutableId
 import org.utbot.framework.plugin.api.MissingState
@@ -16,6 +18,8 @@ import java.util.concurrent.atomic.AtomicInteger
 import soot.SootMethod
 
 
+private val logger = KotlinLogging.logger {  }
+
 /**
  * Gets method or constructor id of SootMethod.
  */
@@ -52,5 +56,5 @@ fun UtSymbolicExecution.hasThisInstance(): Boolean = when {
     // An execution must either have this instance or not.
     // This instance cannot be absent before execution and appear after
     // as well as it cannot be present before execution and disappear after.
-    else -> error("Execution configuration must not change between states")
+    else -> logger.logException { error("Execution configuration must not change between states") }
 }

utbot-framework/src/main/kotlin/org/utbot/framework/util/UtConcreteExecutionResultUtils.kt

@@ -2,6 +2,7 @@ package org.utbot.framework.util
 
 import org.utbot.framework.assemble.AssembleModelGenerator
 import org.utbot.framework.plugin.api.EnvironmentModels
+import org.utbot.framework.plugin.api.MissingState
 import org.utbot.framework.plugin.api.UtExecutionSuccess
 import org.utbot.framework.plugin.api.UtModel
 import org.utbot.instrumentation.instrumentation.execution.UtConcreteExecutionResult
@@ -12,7 +13,7 @@ private fun UtConcreteExecutionResult.updateWithAssembleModels(
 ): UtConcreteExecutionResult {
     val toAssemble: (UtModel) -> UtModel = { assembledUtModels.getOrDefault(it, it) }
 
-    val resolvedStateAfter = EnvironmentModels(
+    val resolvedStateAfter = if (stateAfter is MissingState) MissingState else EnvironmentModels(
         stateAfter.thisInstance?.let { toAssemble(it) },
         stateAfter.parameters.map { toAssemble(it) },
         stateAfter.statics.mapValues { toAssemble(it.value) }

utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/instrumentation/execution/phases/ExecutionPhase.kt

@@ -4,29 +4,27 @@ import com.jetbrains.rd.util.getLogger
 import org.utbot.instrumentation.instrumentation.execution.UtConcreteExecutionResult
 import org.utbot.rd.logMeasure
 
-val logger = getLogger("Executionphase")
+private val logger = getLogger("ExecutionPhase")
 
-abstract class ExecutionPhaseException(override val message: String): Exception()
+abstract class ExecutionPhaseException(override val message: String) : Exception()
 
 // InstrumentationProcessError
 class ExecutionPhaseError(phase: String, override val cause: Throwable) : ExecutionPhaseException(phase)
 
 // Ok
-class ExecutionPhaseStop(phase: String, val result: UtConcreteExecutionResult): ExecutionPhaseException(phase   )
+class ExecutionPhaseStop(phase: String, val result: UtConcreteExecutionResult) : ExecutionPhaseException(phase)
 
 interface ExecutionPhase {
     fun wrapError(e: Throwable): ExecutionPhaseException
 }
 
-fun <T: ExecutionPhase, R> T.start(block: T.() -> R): R =
+fun <T : ExecutionPhase, R> T.start(block: T.() -> R): R =
     try {
         logger.logMeasure(this.javaClass.simpleName) {
             this.block()
         }
-    }
-    catch (e: ExecutionPhaseStop) {
+    } catch (e: ExecutionPhaseStop) {
         throw e
-    }
-    catch (e: Throwable) {
+    } catch (e: Throwable) {
         throw this.wrapError(e)
     }

utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/instrumentation/execution/phases/PhasesController.kt

@@ -60,7 +60,7 @@ class PhasesController(
             withUtContext(context) {
                 phase.block()
             }
-        } ?: throw TimeoutException("Timeout for phase $timeoutForCurrentPhase elapsed, controller timeout - $timeout")
+        } ?: throw TimeoutException("Timeout $timeoutForCurrentPhase ms for phase ${phase.javaClass.simpleName} elapsed, controller timeout - $timeout")
 
         val blockElapsed = stopWatch.get()
         currentlyElapsed += blockElapsed

utbot-rd/src/main/kotlin/org/utbot/rd/UtRdUtil.kt

@@ -133,7 +133,7 @@ inline fun <T> Logger.logMeasure(tag: String = "", block: () -> T): T {
         return block()
     }
     catch (e: Throwable) {
-        this.debug { "exception during evaluating $tag: ${e.printStackTrace()}" }
+        this.debug { "exception during evaluating $tag: ${e.stackTraceToString()}" }
         throw e
     }
     finally {