Refactor Converter.java for improved readability#1
Open
ValentinShakhov wants to merge 1 commit into
Open
Conversation
This commit addresses general readability concerns in the Converter.java class. Changes include: - Renamed the main class from `Main` to `Converter`. - Refactored the `convert` method by introducing a helper method `convertSegmentToString` to handle 3-digit chunks, and changed processing from right-to-left to left-to-right with padding. - Improved variable names for clarity (e.g., `subRes` to `segmentWordsBuilder`, `len` to `inputLength`). - Cleaned up the `main` method by removing unnecessary curly brace blocks. - Refined string concatenation, primarily in `convertSegmentToString`, using `List<String>` and `String.join` for robust spacing. - Added Javadoc comments to the class and public methods to enhance documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses general readability concerns in the Converter.java class.
Changes include:
MaintoConverter.convertmethod by introducing a helper methodconvertSegmentToStringto handle 3-digit chunks, and changed processing from right-to-left to left-to-right with padding.subRestosegmentWordsBuilder,lentoinputLength).mainmethod by removing unnecessary curly brace blocks.convertSegmentToString, usingList<String>andString.joinfor robust spacing.