fix(flutter_plugin): throws PubspecNotFound exception (#199)

Author: marcossevilla

README.md

@@ -44,6 +44,12 @@ Usage: very_good create <output directory>
           [dart_pkg]          Generate a reusable Dart package.
           [flutter_pkg]       Generate a reusable Flutter package.
           [flutter_plugin]    Generate a reusable Flutter federated plugin.
+              --android       The plugin supports the Android platform.
+              --ios           The plugin supports the iOS platform.
+              --web           The plugin supports the Web platform.
+              --linux         The plugin supports the Linux platform.
+              --macos         The plugin supports the macOS platform.
+              --windows       The plugin supports the Windows platform.
 ```
 
 ### What's Included in Very Good Core? 📦

lib/src/cli/cli.dart

@@ -26,6 +26,14 @@ class _Cmd {
     return result;
   }
 
+  static Iterable<Future<ProcessResult>> runWhere({
+    required Future<ProcessResult> Function(FileSystemEntity) run,
+    required bool Function(FileSystemEntity) where,
+    String cwd = '.',
+  }) {
+    return Directory(cwd).listSync(recursive: true).where(where).map(run);
+  }
+
   static void _throwIfProcessFailed(
     ProcessResult pr,
     String process,
@@ -46,3 +54,8 @@ class _Cmd {
     }
   }
 }
+
+bool _isPubspec(FileSystemEntity entity) {
+  if (entity is! File) return false;
+  return p.basename(entity.path) == 'pubspec.yaml';
+}

lib/src/cli/dart_cli.dart

@@ -2,7 +2,7 @@ part of 'cli.dart';
 
 /// Dart CLI
 class Dart {
-  /// Determine whether dart is installed
+  /// Determine whether dart is installed.
   static Future<bool> installed() async {
     try {
       await _Cmd.run('dart', ['--version']);
@@ -13,7 +13,30 @@ class Dart {
   }
 
   /// Apply all fixes (`dart fix --apply`).
-  static Future<void> applyFixes() {
-    return _Cmd.run('dart', ['fix', '--apply']);
+  static Future<void> applyFixes({
+    String cwd = '.',
+    bool recursive = false,
+  }) async {
+    if (!recursive) {
+      final pubspec = File(p.join(cwd, 'pubspec.yaml'));
+      if (!pubspec.existsSync()) throw PubspecNotFound();
+
+      await _Cmd.run('dart', ['fix', '--apply'], workingDirectory: cwd);
+      return;
+    }
+
+    final processes = _Cmd.runWhere(
+      run: (entity) => _Cmd.run(
+        'dart',
+        ['fix', '--apply'],
+        workingDirectory: entity.parent.path,
+      ),
+      where: _isPubspec,
+      cwd: cwd,
+    );
+
+    if (processes.isEmpty) throw PubspecNotFound();
+
+    await Future.wait(processes);
   }
 }

lib/src/cli/flutter_cli.dart

@@ -1,11 +1,21 @@
 part of 'cli.dart';
 
 /// Thrown when `flutter packages get` or `flutter pub get`
-/// is exectuted without a pubspec.yaml
+/// is executed without a `pubspec.yaml`.
 class PubspecNotFound implements Exception {}
 
 /// Flutter CLI
 class Flutter {
+  /// Determine whether flutter is installed.
+  static Future<bool> installed() async {
+    try {
+      await _Cmd.run('flutter', ['--version']);
+      return true;
+    } catch (_) {
+      return false;
+    }
+  }
+
   /// Install flutter dependencies (`flutter packages get`).
   static Future<void> packagesGet({
     String cwd = '.',
@@ -38,16 +48,7 @@ class Flutter {
     );
   }
 
-  /// Determine whether flutter is installed
-  static Future<bool> installed() async {
-    try {
-      await _Cmd.run('flutter', ['--version']);
-      return true;
-    } catch (_) {
-      return false;
-    }
-  }
-
+  /// Install dependencies in directories with a `pubspec.yaml`.
   static Future<void> _installPackages({
     required Future<ProcessResult> Function(String cwd) cmd,
     required String cwd,
@@ -61,7 +62,7 @@ class Flutter {
       return;
     }
 
-    final processes = _process(
+    final processes = _Cmd.runWhere(
       run: (entity) => cmd(entity.parent.path),
       where: _isPubspec,
       cwd: cwd,
@@ -71,17 +72,4 @@ class Flutter {
 
     await Future.wait(processes);
   }
-
-  static Iterable<Future<ProcessResult>> _process({
-    required Future<ProcessResult> Function(FileSystemEntity) run,
-    required bool Function(FileSystemEntity) where,
-    String cwd = '.',
-  }) {
-    return Directory(cwd).listSync(recursive: true).where(where).map(run);
-  }
-}
-
-bool _isPubspec(FileSystemEntity entity) {
-  if (entity is! File) return false;
-  return p.basename(entity.path) == 'pubspec.yaml';
 }

lib/src/commands/create.dart

@@ -255,8 +255,6 @@ class CreateCommand extends Command<int> {
   }
 }
 
-/// Extension on String to parse booleans.
-extension StringToBoolX on String {
-  /// Returns if `String` is equal to `true`.
+extension on String {
   bool parseBool() => toLowerCase() == 'true';
 }