Skip to content

fix(test): run tests with --no-pub#322

Merged
felangel merged 1 commit intomainfrom
fix/test-no-pub
Mar 18, 2022
Merged

fix(test): run tests with --no-pub#322
felangel merged 1 commit intomainfrom
fix/test-no-pub

Conversation

@felangel
Copy link
Contributor

Description

  • fix(test): run tests with --no-pub

Context

When running tests without --no-pub if a warning is output during package installation, it is reported via stderr so the test_runner interprets it as an error and exits the process. This change always uses --no-pub during test execution to resolve this issue.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the bug Something isn't working as expected label Mar 18, 2022
@felangel felangel requested a review from jorgecoca as a code owner March 18, 2022 18:45
@felangel felangel self-assigned this Mar 18, 2022
@felangel felangel merged commit 005c2aa into main Mar 18, 2022
@felangel felangel deleted the fix/test-no-pub branch March 18, 2022 18:52
@felangel felangel mentioned this pull request Mar 21, 2022
7 tasks
ahsanf pushed a commit to Arkabyte-Teknologi/very_good_cli that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants