Skip to content

feat(test): add --update-goldens#341

Merged
felangel merged 2 commits intomainfrom
feat/test-update-goldens
Mar 25, 2022
Merged

feat(test): add --update-goldens#341
felangel merged 2 commits intomainfrom
feat/test-update-goldens

Conversation

@felangel
Copy link
Contributor

@felangel felangel commented Mar 25, 2022

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the feature A new feature or request label Mar 25, 2022
@felangel felangel self-assigned this Mar 25, 2022
@felangel felangel requested a review from jorgecoca as a code owner March 25, 2022 20:53
erickzanardo
erickzanardo previously approved these changes Mar 25, 2022
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is golden! LGTM!

@felangel felangel merged commit 6483d0a into main Mar 25, 2022
@felangel felangel deleted the feat/test-update-goldens branch March 25, 2022 21:42
@felangel felangel mentioned this pull request Mar 25, 2022
7 tasks
ahsanf pushed a commit to Arkabyte-Teknologi/very_good_cli that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Pass through flags for very_good test to flutter test for things like --update-goldens

2 participants