fix: recursive min coverage#647
Merged
erickzanardo merged 14 commits intoVeryGoodOpenSource:mainfrom Feb 21, 2023
Merged
Conversation
willhlas
force-pushed
the
fix/recursive-min-coverage
branch
from
e1a52f7 to
25944c9
Compare
willhlas
requested review from
felangel,
renancaraujo and
wolfenrain
as code owners
wolfenrain
previously approved these changes
Feb 9, 2023
felangel
reviewed
Feb 9, 2023
felangel
suggested changes
Feb 9, 2023
Contributor
felangel
left a comment
felangel
left a comment
There was a problem hiding this comment.
Can we add a test for this fix to ensure it doesn't happen again?
This reverts commit a367603.
renancaraujo
previously approved these changes
Feb 16, 2023
felangel
previously approved these changes
Feb 16, 2023
erickzanardo
approved these changes
Feb 17, 2023
wolfenrain
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where running
--min-coveragewith--recursivewould not throw error if min coverage was not met.Closes #389
Type of Change