fix: test optimizer to import files as valid dart names#658
Merged
Conversation
alestiago
requested review from
felangel,
renancaraujo and
wolfenrain
as code owners
alestiago
commented
Feb 20, 2023
wolfenrain
reviewed
Feb 20, 2023
alestiago
commented
Feb 21, 2023
wolfenrain
previously approved these changes
Feb 21, 2023
…github.com/VeryGoodOpenSource/very_good_cli into fix/square-brackets-not-allowed-as-imports
renancaraujo
approved these changes
Feb 22, 2023
wolfenrain
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of importing files as a snaked case name of the relative path, the test files are assigned an alphabetic identifier.
Before:
After:
Resolves #648
Type of Change