From 61c37c9a232e335369d54090e4800399a62a8c17 Mon Sep 17 00:00:00 2001 From: Surat Das Date: Sun, 26 Dec 2021 09:54:58 -0800 Subject: [PATCH 1/2] Addresses issue #342 - Call VRT with minimum parameters. --- .../sdk_java/VisualRegressionTrackerConfig.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerConfig.java b/src/main/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerConfig.java index de03480..ccba92c 100644 --- a/src/main/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerConfig.java +++ b/src/main/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerConfig.java @@ -15,15 +15,15 @@ public class VisualRegressionTrackerConfig { @NonNull private final String apiUrl; @NonNull - private final String project; - @NonNull private final String apiKey; @NonNull - private final String branchName; + private final String project; @Builder.Default - private Boolean enableSoftAssert = false; + private String branchName = null; @Builder.Default private String ciBuildId = null; @Builder.Default + private Boolean enableSoftAssert = false; + @Builder.Default private int httpTimeoutInSeconds = 10; } From 1b17361037ee00c45142d571ace4180ec26e9df3 Mon Sep 17 00:00:00 2001 From: Surat Das Date: Sun, 26 Dec 2021 11:05:05 -0800 Subject: [PATCH 2/2] Fixed test. --- .../sdk_java/VisualRegressionTrackerTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerTest.java b/src/test/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerTest.java index 1b68791..633c468 100755 --- a/src/test/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerTest.java +++ b/src/test/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerTest.java @@ -67,8 +67,8 @@ public void setup() { "733c148e-ef70-4e6d-9ae5-ab22263697cc", "XHGDZDFD3GMJDNM87JKEMP0JS1G5", "develop", - false, CI_BUILD_ID, + false, HTTP_TIMEOUT); vrt = new VisualRegressionTracker(config); vrtMocked = mock(VisualRegressionTracker.class);